fixed some tests

microsoft · Mar 8, 2017 · 497797e · 497797e
1 parent 9f91c81
commit 497797e
Show file tree

Hide file tree

Showing 5 changed files with 146 additions and 4 deletions.
diff --git a/test/sqlsrv/sqlsrv_fetch_datetime_as_strings.phpt b/test/sqlsrv/sqlsrv_fetch_datetime_as_strings.phpt
@@ -51,6 +51,11 @@ function FetchData($stmt1, $stmt2, $numRows)
         if ($value1 !== $value2)
             echo "Data corrupted: $value1 !== $value2\n";
 
+        $value1 = $obj->c4_smalldatetime;
+        $value2 = $row['c4_smalldatetime'];
+
+        if ($value1 !== $value2)
+            echo "Data corrupted: $value1 !== $value2\n";
     } while (++$rowFetched < $numRows);    
 }
 
@@ -84,7 +89,6 @@ function Repro()
     {
         set_time_limit(0);  
         sqlsrv_configure('WarningsReturnAsErrors', 1);  
-        sqlsrv_get_config('WarningsReturnAsErrors');    
 
         require_once("autonomous_setup.php");
 

diff --git a/test/sqlsrv/sqlsrv_fetch_field_twice_data_types.phpt b/test/sqlsrv/sqlsrv_fetch_field_twice_data_types.phpt
@@ -0,0 +1,141 @@
+--TEST--
+Test calling sqlsrv_get_field twice in a row. Intentionally trigger various error messages.
+--FILE--
+<?php
+include 'tools.inc';
+
+function FetchFieldTwice($conn)
+{
+    $tableName = GetTempTableName();
+
+    $stmt = sqlsrv_query($conn, "CREATE TABLE $tableName ([c1_int] int, [c2_float] float, [c3_real] real, [c4_datetime] datetime)"); 
+    sqlsrv_free_stmt($stmt);
+
+    $query = "INSERT INTO $tableName ([c1_int], [c2_float], [c3_real], [c4_datetime]) VALUES ((968580013), (1.09), (3.438), ('1756-04-16 23:27:09.131'))";
+    $stmt = sqlsrv_query($conn, $query);
+    sqlsrv_execute($stmt);
+    PrintError();   // errors expected here 
+
+    sqlsrv_free_stmt($stmt);    
+
+    $query = "SELECT * FROM $tableName";
+    $stmt = sqlsrv_prepare($conn, $query);
+    $result = sqlsrv_fetch($stmt); 
+    if ($result !== false) 
+    {
+        echo "Fetch should have failed!\n";
+    }   
+    PrintError();   // errors expected here 
+
+    if (! sqlsrv_execute($stmt)) 
+    { 
+        FatalError("Errors in executing statement.\n"); 
+    }
+
+    $numFields = sqlsrv_num_fields($stmt);   
+    $metadata = sqlsrv_field_metadata($stmt);
+    while ($result = sqlsrv_fetch($stmt))
+    {        
+        for ($i = -1; $i <= $numFields; $i++)
+        {
+            FetchField($stmt, $i, $metadata, false);
+            FetchField($stmt, $i, $metadata, true);
+        }
+    }
+
+    sqlsrv_free_stmt($stmt);       
+}
+
+function FetchField($stmt, $idx, $metadata, $errorExpected)
+{   
+    if ($idx < 0 || $idx >= count($metadata))
+    {
+        $value1 = sqlsrv_get_field($stmt, $idx);          
+        PrintError(true);   // errors expected because the idx is out of bound
+    }
+    else
+    {
+        $colType = $metadata[$idx]['Type'];
+
+        if (IsDateTime($colType))
+        {
+            $value1 = sqlsrv_get_field($stmt, $idx, SQLSRV_PHPTYPE_STRING(SQLSRV_ENC_CHAR));                
+        }
+        else
+        {
+            $value1 = sqlsrv_get_field($stmt, $idx);  
+        }            
+        var_dump($value1);
+
+        PrintError($errorExpected);
+    }    
+}
+
+function PrintError($errorExpected = true)
+{
+    $errors = sqlsrv_errors(SQLSRV_ERR_ALL);
+    if (count($errors) > 0)
+    {
+        $e = $errors[0];
+        var_dump($e['message']);            
+    }            
+    else if ($errorExpected)
+    {
+        echo "An error is expected!\n";
+    }
+}
+
+function Repro()
+{
+    StartTest("sqlsrv_fetch_field_twice_data_types");
+    try
+    {
+        set_time_limit(0);  
+        sqlsrv_configure('WarningsReturnAsErrors', 1);  
+
+        require_once("autonomous_setup.php");
+
+        // Connect
+        $connectionInfo = array("UID"=>$username, "PWD"=>$password);
+        $conn = sqlsrv_connect($serverName, $connectionInfo);
+        if( !$conn ) { FatalError("Could not connect.\n"); }
+
+        FetchFieldTwice($conn);
+
+        sqlsrv_close($conn);           
+    }
+    catch (Exception $e)
+    {
+        echo $e->getMessage();
+    }
+    echo "\nDone\n";
+    EndTest("sqlsrv_fetch_field_twice_data_types");
+}
+
+Repro();
+
+?>
+--EXPECT--
+
+...Starting 'sqlsrv_fetch_field_twice_data_types' test...
+string(79) "A statement must be prepared with sqlsrv_prepare before calling sqlsrv_execute."
+string(63) "The statement must be executed before results can be retrieved."
+string(52) "An invalid parameter was passed to sqlsrv_get_field."
+string(52) "An invalid parameter was passed to sqlsrv_get_field."
+int(968580013)
+bool(false)
+string(25) "Field 0 returned no data."
+float(1.09)
+bool(false)
+string(25) "Field 1 returned no data."
+float(3.4379999637604)
+bool(false)
+string(25) "Field 2 returned no data."
+string(23) "1756-04-16 23:27:09.130"
+bool(false)
+string(25) "Field 3 returned no data."
+string(52) "An invalid parameter was passed to sqlsrv_get_field."
+string(52) "An invalid parameter was passed to sqlsrv_get_field."
+
+Done
+...Test 'sqlsrv_fetch_field_twice_data_types' completed successfully.
diff --git a/test/sqlsrv/sqlsrv_param_query_data_types.phpt b/test/sqlsrv/sqlsrv_param_query_data_types.phpt
@@ -29,7 +29,6 @@ function Repro()
     {
         set_time_limit(0);  
         sqlsrv_configure('WarningsReturnAsErrors', 1);  
-        sqlsrv_get_config('WarningsReturnAsErrors');    
 
         require_once("autonomous_setup.php");
         $database = "tempdb";

diff --git a/test/sqlsrv/sqlsrv_statement_query_timeout.phpt b/test/sqlsrv/sqlsrv_statement_query_timeout.phpt
@@ -37,7 +37,6 @@ function Repro()
     {
         set_time_limit(0);  
         sqlsrv_configure('WarningsReturnAsErrors', 1);  
-        sqlsrv_get_config('WarningsReturnAsErrors');    
 
         require_once("autonomous_setup.php");
         $database = "tempdb";

diff --git a/test/sqlsrv/sqlsrv_statement_query_timeout_transaction.phpt b/test/sqlsrv/sqlsrv_statement_query_timeout_transaction.phpt
@@ -48,7 +48,6 @@ function Repro()
     {
         set_time_limit(0);  
         sqlsrv_configure('WarningsReturnAsErrors', 1);  
-        sqlsrv_get_config('WarningsReturnAsErrors');    
 
         require_once("autonomous_setup.php");