Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco-editor depends on monaco-editor-core types #2460

Closed
remcohaszing opened this issue Apr 29, 2021 · 0 comments
Closed

monaco-editor depends on monaco-editor-core types #2460

remcohaszing opened this issue Apr 29, 2021 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@remcohaszing
Copy link
Contributor

The types defined by monaco-editor/esm/vs/language/json/fillers/monaco-editor-core.d.ts re-exports everything from the monaco-editor-core package. It should export types from ../../../editor/editor.api instead, just like the JS file the types are for.

#2451 would also fix it.

monaco-editor version: 0.23.0
Browser: N/A
OS: Ubuntu 20.10
Playground code that reproduces the issue: N/A

import 'monaco-editor/esm/vs/language/json/monaco.contribution';
$ node_modules/.bin/tsc
node_modules/monaco-editor/esm/vs/language/json/fillers/monaco-editor-core.d.ts:1:15 - error TS2307: Cannot find module 'monaco-editor-core' or its corresponding type declarations.

1 export * from 'monaco-editor-core';
                ~~~~~~~~~~~~~~~~~~~~

node_modules/monaco-editor/esm/vs/language/json/monaco.contribution.d.ts:1:10 - error TS2305: Module '"./fillers/monaco-editor-core"' has no exported member 'IEvent'.

1 import { IEvent } from './fillers/monaco-editor-core';
           ~~~~~~


Found 2 errors.
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label May 12, 2021
@alexdima alexdima added this to the April 2021 milestone May 12, 2021
@alexdima alexdima self-assigned this May 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants