Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make monaco-editor use monaco-editor-core and friends #2451

Open
remcohaszing opened this issue Apr 21, 2021 · 0 comments
Open

Make monaco-editor use monaco-editor-core and friends #2451

remcohaszing opened this issue Apr 21, 2021 · 0 comments
Labels
feature-request Request for new features or functionality integration

Comments

@remcohaszing
Copy link
Contributor

Recently I created a pull request for monaco-yaml to use Monaco imports instead of the global Monaco object (remcohaszing/monaco-yaml#48).

To implement this, I had to make a choice: should monaco-yaml support monaco-editor or monaco-editor-core?

I don’t think Monaco plugins should have to make this choice. I think monaco-editor should become a simple package that uses monaco-editor-core, monaco-json, monaco-css, monaco-html, and monaco-typescript as regular dependencies instead of bundling them. This gives third party plugins to create an implementation based on monaco-editor-core that also works for monaco-editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality integration
Projects
None yet
Development

No branches or pull requests

2 participants