Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shadow on NavigationView pane #96

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Add shadow on NavigationView pane #96

merged 2 commits into from
Dec 18, 2018

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Dec 15, 2018 •
edited
Loading

Internal Issue
Adding shadows for NavigationView.

@kaiguo kaiguo requested review from licanhua, a team and chrisglein December 15, 2018 08:01
jevansaks
jevansaks approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@jevansaks jevansaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions.

licanhua
licanhua approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@licanhua licanhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kaiguo kaiguo merged commit ace0afe into master Dec 18, 2018
@kaiguo kaiguo deleted the user/kaigu/navigationview-shadow branch December 18, 2018 05:32
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.1.190131001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

StephenLPeters pushed a commit that referenced this pull request Feb 9, 2019
@kaiguo
Add shadow on NavigationView pane (#96)
bdb25d6 
* Apply shadow on NavigationView

* Cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@licanhua licanhua licanhua approved these changes

@jevansaks jevansaks jevansaks approved these changes

@chrisglein chrisglein chrisglein approved these changes

@kmahone kmahone kmahone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaiguo @msft-github-bot @licanhua @jevansaks @chrisglein @kmahone