Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Scroller.Content flicker during rasterization for Issue #541. #882

Merged
merged 4 commits into from
Jun 24, 2019
Merged

Fixing Scroller.Content flicker during rasterization for Issue #541. #882

merged 4 commits into from
Jun 24, 2019

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Jun 14, 2019

Fixes #541
During the Scroller's Content rasterization, the Content.Scale animation alone was temporarily halted.
If a view change was started during that pause (for example through a mouse wheel input), the Content.Translation changes would still be reflected visually, causing the Content to shift momentarily.
The fix is two-fold:

  • not only stop the Content.Scale façade animation, but also momentarily stop the Content.Translation façade animation. As a result no unwanted visual translation occurs during the short pause.
  • prematurely restart both animations if the InteractionTracker leaves the Idle state during the pause. This guarantees a faster visual feedback for the view change.
    The tests that use Scroller.ZoomTo/ZoomBy/ZoomFrom were updated accordingly.

@RBrid RBrid added bug Something isn't working area-Scrolling labels Jun 14, 2019
@RBrid RBrid requested a review from a team June 14, 2019 22:28
@RBrid RBrid self-assigned this Jun 14, 2019
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Jun 14, 2019
StephenLPeters
StephenLPeters approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RBrid RBrid merged commit ca0ecdd into master Jun 24, 2019
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190702001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Jul 2, 2019
Closed
@RBrid RBrid deleted the user/rbrid/ScrollerFlickerDuringRasterization branch August 19, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees

@RBrid RBrid

Labels
area-Scrolling bug Something isn't working release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScrollViewer / Scroller doesn't re-rasterize the content after a zoom
4 participants
@RBrid @msft-github-bot @StephenLPeters @jevansaks