Add null check for top pane title #5526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelwgn
approved these changes
Jul 21, 2021
ranjeshj
approved these changes
Jul 22, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@MartinZikmund, could you please merge with the latest main and start a new pipeline with /azp run ? |
|
You will not be able to start the pipelines but if you could merge main that would be great! |
4d37255 to
fa3ec9b
Compare
|
@RBrid @StephenLPeters done 👍 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@StephenLPeters FYI merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a null check to ensure
NavigationViewdoes not crash when trying to accessPaneTitleOnTopPanewhen it is not part of the template.Motivation and Context
Fixes #5525
How Has This Been Tested?
Locally and in Uno Platform port.