Update gamepad helper #3152
Update gamepad helper #3152
Conversation
|
@chingucoding can you pull master to pick up the CI build fix that just went in? |
| { | ||
| Wait.ForMilliseconds(10); | ||
| } | ||
| } |
There was a problem hiding this comment.
I prefer using something like this
There was a problem hiding this comment.
Switched to that. Is there any documentation on this? I can't seem to find any helpful documents on the Microsoft.Windows.Apps.Test.Foundation namespace or TAEF 🤔
There was a problem hiding this comment.
I think unfortunately not, @kmahone might know something
There was a problem hiding this comment.
Also just to be sure, TryWait in this case tries to either wait for the value to change or continue after 50 milliseconds right?
There was a problem hiding this comment.
You should be able to see the source by using F12 in VS. I think that after the timespan this will throw, and I think there is an optional parameter to make it continue without throwing instead
There was a problem hiding this comment.
Hitting F12 only gives me this:
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
This updates the GamePad helper with the hope to improve the reliability for tests that inject GamePad input.
General idea was: Press button, wait 50 milliseconds, lift button.
New idea: Press button, wait for testframe to report input was received, wait for idle and lift button again.
If the testframe doesn't have the checkbox to report it received the input, we fallback to the old behavior.
Motivation and Context
How Has This Been Tested?
Ran tests multiple times, though they were reliable on my machine before this change too.
How should we test this?
I think we should run CI with the changes, if everything goes fine, we can try reenabling tests and run the CI multiple times to determine if those tests are reliable enough.
The tests that are currently disabled due to gamepad issues are:
Screenshots (if appropriate):