Fix issue with NavigationView ShoulderNavigation always not behaving correctly #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelwgn
commented
Aug 17, 2020
|
|
||
| if (!IsTopNavigationView() | ||
| || !IsNavigationViewListSingleSelectionFollowsFocus() |
There was a problem hiding this comment.
Should we remove this function altogether? This is more or less a relic now since we are not using ListView anymore and the function doesn't do anything we couldn't do elsewhere (and we already do in a few cases).
There was a problem hiding this comment.
It does seem pretty trivial, I think it would probably be easier to parse the code if we removed it
In reply to: 471540013 [](ancestors = 471540013)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@chingucoding can you merge master to pick up the CI build fix that just went in? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The check to determine whether selection should update or not was faulty. Thanks you @pavelshapovalov for pointing that out in your issue!
Motivation and Context
Closes #328
How Has This Been Tested?
Add two new interaction tests.
Since those tests rely on gamepad input, maybe we should disable them right away until we have a more reliable gamepad input logic? (See #2202 for more context).
Screenshots (if appropriate):