-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport CommandBarFlyout shadow fix #281
Merged
kaiguo
merged 5 commits into
master
from
user/kaiguo/backport-commandbarflyout-shadow-fix
Feb 8, 2019
Merged
Backport CommandBarFlyout shadow fix #281
kaiguo
merged 5 commits into
master
from
user/kaiguo/backport-commandbarflyout-shadow-fix
Feb 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevansaks
reviewed
Feb 7, 2019
jevansaks
reviewed
Feb 7, 2019
jevansaks
reviewed
Feb 7, 2019
jevansaks
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment, but otherwise looks good.
Co-Authored-By: kaiguo <guokai.ok@gmail.com>
chrisglein
approved these changes
Feb 8, 2019
StephenLPeters
pushed a commit
that referenced
this pull request
Feb 9, 2019
* Port CommandBarFlyout fix * Add USE_INSIDER_SDK * UiElement10 * Update dev/CommandBarFlyout/CommandBarFlyoutCommandBar.cpp Co-Authored-By: kaiguo <guokai.ok@gmail.com> * null check update
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport MUX changes in PR 2700234.
Added USE_INSIDER_SDK for shadow api usages.