Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport CommandBarFlyout shadow fix #281

Merged
merged 5 commits into from
Feb 8, 2019

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Feb 7, 2019

Backport MUX changes in PR 2700234.

Added USE_INSIDER_SDK for shadow api usages.

@kaiguo kaiguo requested a review from chrisglein February 7, 2019 21:31
@kaiguo kaiguo requested a review from a team as a code owner February 7, 2019 21:31
@kaiguo kaiguo changed the title Backport commandbarflyout shadow fix Backport commandBarFlyout shadow fix Feb 7, 2019
@kaiguo kaiguo changed the title Backport commandBarFlyout shadow fix Backport CommandBarFlyout shadow fix Feb 7, 2019
Copy link
Member

@jevansaks jevansaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment, but otherwise looks good.

@kaiguo kaiguo merged commit a348e0b into master Feb 8, 2019
StephenLPeters pushed a commit that referenced this pull request Feb 9, 2019
* Port CommandBarFlyout fix

* Add USE_INSIDER_SDK

* UiElement10

* Update dev/CommandBarFlyout/CommandBarFlyoutCommandBar.cpp

Co-Authored-By: kaiguo <guokai.ok@gmail.com>

* null check update
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.1.190219001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

@kaiguo kaiguo deleted the user/kaiguo/backport-commandbarflyout-shadow-fix branch March 19, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants