Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automation Peer fix for Hierarchical NavigationView #2627

Merged
merged 6 commits into from
Jun 12, 2020
Merged

Automation Peer fix for Hierarchical NavigationView #2627

merged 6 commits into from
Jun 12, 2020

Conversation

ojhad
Copy link
Contributor

@ojhad ojhad commented Jun 9, 2020

Description

  1. Updates the automation peer to properly report size and position for hierarchy.
  2. Updates the automation peer to report correct item level (was being 0-indexed previously, but to keep consistent with TreeView it should start at level one)

Motivation and Context

Fixes #2560

How Has This Been Tested?

Added interaction test and manually tested.

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jun 9, 2020
@ranjeshj ranjeshj added area-NavigationView NavView control needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) team-Controls Issue for the Controls team labels Jun 9, 2020
@ojhad
Copy link
Contributor Author

ojhad commented Jun 9, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Jun 9, 2020
StephenLPeters
StephenLPeters approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ojhad
Copy link
Contributor Author

ojhad commented Jun 11, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ojhad
Copy link
Contributor Author

ojhad commented Jun 11, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcelwgn
Copy link
Collaborator

Seems like the pipeline flat out broke down. The build release x85 job is now running for over a day now.

Should we cancel and requeue @StephenLPeters ?

@ojhad
Copy link
Contributor Author

ojhad commented Jun 12, 2020

Seems like the pipeline flat out broke down.

Hmm, yeah, looks like an out of memory error during the build. I've queued a re-run, lets see if that fixes it.

@ojhad ojhad merged commit 6e99a41 into master Jun 12, 2020
@ojhad ojhad deleted the user/ojhad/automationpeerfix branch June 12, 2020 22:43
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jun 14, 2020
@Kinnara
Automation Peer fix for Hierarchical NavigationView (microsoft/micros…
8624822 
…oft-ui-xaml#2627)
ranjeshj pushed a commit that referenced this pull request Jul 7, 2020
@ojhad @ranjeshj
Automation Peer fix for Hierarchical NavigationView (#2627)
6aa3549 
* fixed left nav uia

* updated top nav

* added test

* cleanup

* fixed level reporting

* addressed comments
@ranjeshj ranjeshj removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Aug 12, 2020
@StephenLPeters StephenLPeters mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees
No one assigned
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Narrator reading wrong index for Hierarchical Navigation items.
5 participants
@ojhad @marcelwgn @StephenLPeters @ranjeshj @msft-github-bot