Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear DataContext of cleared elements in ItemsRepeater #2626

Merged
merged 5 commits into from
Jun 12, 2020
Merged

Clear DataContext of cleared elements in ItemsRepeater #2626

merged 5 commits into from
Jun 12, 2020

Conversation

marcelwgn
Copy link
Collaborator

@marcelwgn marcelwgn commented Jun 8, 2020 •
edited
Loading

Description

When we set the DataContext, we save that fact in the VirtualizationInformation for that element, when that element gets cleared, we look up in the VirtualizationInformation whether we should need to clear the DataContext too, and do that if necessary.

Motivation and Context

Fixes #2384

How Has This Been Tested?

Manually through debugging, added new API test.

Screenshots (if appropriate):

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jun 8, 2020
@ranjeshj
Copy link
Contributor

ranjeshj commented Jun 9, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters added area-ItemsRepeater team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 9, 2020
StephenLPeters
StephenLPeters approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters
Copy link
Contributor

@ranjeshj I don't think I have a perfect understanding of the change so I'm going to wait for your sign off to merge this.

@ranjeshj ranjeshj merged commit e9bd88e into microsoft:master Jun 12, 2020
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jun 14, 2020
@Kinnara
Clear DataContext of cleared elements in ItemsRepeater (microsoft/mic…
5ebdc90 
…rosoft-ui-xaml#2626)
@grokys grokys mentioned this pull request Jun 16, 2020
Merged
5 tasks
@marcelwgn marcelwgn mentioned this pull request Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

@ranjeshj ranjeshj ranjeshj approved these changes

Assignees
No one assigned
Labels
area-ItemsRepeater team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in KernelBase.dll when using nested ItemsRepeater
4 participants
@marcelwgn @ranjeshj @StephenLPeters @msft-github-bot