Make TreeView SelectedItem a DP #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranjeshj
reviewed
May 27, 2020
dev/TreeView/TreeView.cpp
Outdated
| @@ -292,6 +292,29 @@ void TreeView::OnListControlSelectionChanged(const winrt::IInspectable& sender, | |||
| if (SelectionMode() == winrt::TreeViewSelectionMode::Single) | |||
| { | |||
| RaiseSelectionChanged(args.AddedItems(), args.RemovedItems()); | |||
|
|
|||
| const auto newSelectedItem = [this,args]() { | |||
There was a problem hiding this comment.
this [](start = 38, length = 4)
Is the this capture needed here?
There was a problem hiding this comment.
No it wasn't needed, removed it.
dev/TreeView/TreeView.cpp
Outdated
| // Checking if new value is different to the currently internally selected item | ||
| if (args.NewValue() != selected) | ||
| { | ||
| if (auto listControl = ListControl()) |
There was a problem hiding this comment.
auto [](start = 16, length = 4)
nit: const
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the SelectedItem a DP and adds interaction test to verify two way binding.
Motivation and Context
Closes #2458
How Has This Been Tested?
Add new interaction test
Screenshots (if appropriate):