Selecting custom color on non-100% DPI crashes settings #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahone
reviewed
Jan 30, 2019
kmahone
reviewed
Jan 30, 2019
kmahone
reviewed
Jan 30, 2019
kmahone
approved these changes
Jan 30, 2019
|
🎉 Handy links: |
StephenLPeters
pushed a commit
that referenced
this pull request
Feb 9, 2019
* Fixed an issue where we were rounding in one place and not in another.
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the context of
ColorSpectrum::CreateBitmapsAndColorMap(), minDimension is a non-integer value. We call round() on the value forpixelWidthandpixelHeightwhich we pass intoCreateSurfaceFromPixelData(), but we just cast the value to an integer type without rounding when we callbgraMinPixelData->reserve(). As a result, the explicit pixel width and height that we use there can be out of sync with the implicit pixel width and height that we use to size the vectors into which we put color information. Since we round down when sizing the vector and up when filling the vector, we can run into a buffer overflow in this case.