TreeView: Set IsExpanded when last child has been removed #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
My WinUI build system is currently broken so I can't check myself. What happens when the items source for a treeview item is changed and the item was previously expanded? Does the IsExpanded state change to collapsed in this situation? |
|
In what scenario exactly? If you remove and readd the collection, I don't think we could restore the IsExpanded state anyway. But If you look at the tests, in cases where the list changes, I think in most cases the IsExpanded state won't change. |
|
Managed to build WinUI and the test app again, seems fine to me. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
pushed a commit
that referenced
this pull request
Jul 7, 2020
* Add test for IsExpanded not being set to false when removing last child * Fix issue with setting IsExpanded not to false when removing last child * Fix test failures * Fix test
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add code that set's the IsExpanded of a node to false when it's last child has been removed.
Motivation and Context
Fixes #2332
How Has This Been Tested?
Add new API test
Screenshots (if appropriate):