A few small changes #1234

teaP · 2019-08-28T22:38:52Z

CanDragTabs is false by default, just like ListView (but reorder is still on by default; we expect everyone to want it).
SelectedIndex is 0 by default, so if the app author doesn't specify, then the first tab will get selected, avoiding the weird state of having no selected tab.
When creating a TabView in a new appwindow, sometimes it has 0 size at the beginning; in that case we shouldn't measure tabs, we should just skip it and wait until we have a real size. I actually only added one line, but github seems confused about the diff because things got indented...
Changed some colors and tweaked margins based on designer feedback.
Fixed corner radius to be based on OverlayCornerRadius.

adrientetar · 2019-08-28T22:49:27Z

I actually only added one line, but github seems confused about the diff because things got indented...

You can add ?w=1 to the github url to hide whitespace-only changes

dev/TabView/TabView.xaml

jevansaks · 2019-08-28T22:58:15Z

If we go from 0 items to non-0 items, is there logic that will select the first item? I'm just wondering about the data-bound scenario where the items may populate after the control loads.

teaP · 2019-08-29T16:49:29Z

If we go from 0 items to non-0 items, is there logic that will select the first item? I'm just wondering about the data-bound scenario where the items may populate after the control loads.

I do have a data-bound scenario and it works. ListView may be helping us out here.

jevansaks · 2019-08-30T16:33:37Z

/azp run

azure-pipelines · 2019-08-30T16:33:53Z

Azure Pipelines successfully started running 1 pipeline(s).

DHowett-MSFT · 2019-09-04T00:01:59Z

dev/TabView/TabView_themeresources.xaml

@@ -6,7 +6,7 @@

    <ResourceDictionary.ThemeDictionaries>
        <ResourceDictionary x:Key="Light">
-            <StaticResource x:Key="TabViewBackground"                        ResourceKey="SystemControlBackgroundBaseLowBrush" />


was it intentional to change this for Light but not for Dark and HC?

Unlikely, especially if you are seeing a bug. Are you able to contribute a fix? @teaP is out this week.

It was actually intentional. PM, design, and I agreed to make the background slightly lighter for light theme but not darker for dark theme.

ghost · 2021-08-17T17:53:52Z

🎉This issue was addressed in #5432, which has now been successfully released as Microsoft.UI.Xaml v2.7.0-prerelease.210816001.:tada:

Handy links:

ghost · 2021-08-19T00:14:12Z

🎉This issue was addressed in #5531, which has now been successfully released as Microsoft.UI.Xaml v2.6.2-prerelease.210818003.:tada:

Handy links:

ghost · 2021-08-20T17:27:21Z

🎉This issue was addressed in #5628, which has now been successfully released as Microsoft.UI.Xaml v2.6.2.:tada:

Handy links:

ghost · 2021-08-20T17:27:51Z

🎉This issue was addressed in #5472, which has now been successfully released as Microsoft.UI.Xaml v2.6.2.:tada:

Handy links:

ghost · 2021-08-20T17:28:00Z

🎉This issue was addressed in #5447, which has now been successfully released as Microsoft.UI.Xaml v2.6.2.:tada:

Handy links:

ghost · 2021-08-20T17:28:12Z

🎉This issue was addressed in #5432, which has now been successfully released as Microsoft.UI.Xaml v2.6.2.:tada:

Handy links:

ghost · 2021-08-20T17:28:27Z

🎉This issue was addressed in #5359, which has now been successfully released as Microsoft.UI.Xaml v2.6.2.:tada:

Handy links:

ghost · 2022-01-19T19:21:36Z

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml vMicrosoft.Experimental.UI.Xaml.2.8.0-prerelease.220118001.:tada:

Handy links:

ghost · 2022-04-14T13:44:27Z

🎉This issue was addressed in #5870, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

ghost · 2022-04-14T13:44:57Z

🎉This issue was addressed in #5930, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

ghost · 2022-04-14T13:45:07Z

🎉This issue was addressed in #5910, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

ghost · 2022-04-14T13:46:07Z

🎉This issue was addressed in #6004, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

ghost · 2022-04-14T13:46:19Z

🎉This issue was addressed in #5968, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

ghost · 2022-04-14T13:47:10Z

🎉This issue was addressed in #6138, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

ghost · 2022-04-14T13:47:31Z

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

ghost · 2022-07-13T00:20:56Z

🎉This issue was addressed in #5870, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

ghost · 2022-07-13T00:21:38Z

🎉This issue was addressed in #5930, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

ghost · 2022-07-13T00:21:59Z

🎉This issue was addressed in #5973, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

ghost · 2022-07-13T00:22:08Z

🎉This issue was addressed in #5910, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

ghost · 2022-07-13T00:23:26Z

🎉This issue was addressed in #6004, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

ghost · 2022-07-13T00:23:41Z

🎉This issue was addressed in #5968, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

ghost · 2022-07-13T00:24:32Z

🎉This issue was addressed in #6142, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

ghost · 2022-07-13T00:24:47Z

🎉This issue was addressed in #6138, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

ghost · 2022-07-13T00:25:17Z

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

ghost · 2022-07-18T17:54:04Z

🎉This issue was addressed in #5870, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

ghost · 2022-07-18T17:54:49Z

🎉This issue was addressed in #5930, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

ghost · 2022-07-18T17:55:13Z

🎉This issue was addressed in #5973, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

ghost · 2022-07-18T17:55:22Z

🎉This issue was addressed in #5910, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

ghost · 2022-07-18T17:56:52Z

🎉This issue was addressed in #6004, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

ghost · 2022-07-18T17:57:07Z

🎉This issue was addressed in #5968, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

ghost · 2022-07-18T17:58:04Z

🎉This issue was addressed in #6142, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

ghost · 2022-07-18T17:58:19Z

🎉This issue was addressed in #6138, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

ghost · 2022-07-18T17:58:55Z

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

ghost · 2022-08-31T17:46:02Z

🎉This issue was addressed in #7197, which has now been successfully released as Microsoft.UI.Xaml v2.8.2-prerelease.220830001.:tada:

Handy links:

ghost · 2023-01-03T18:29:11Z

🎉This issue was addressed in #5870, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

ghost · 2023-01-03T18:29:47Z

🎉This issue was addressed in #5930, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

ghost · 2023-01-03T18:29:59Z

🎉This issue was addressed in #5910, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

ghost · 2023-01-03T18:30:58Z

🎉This issue was addressed in #6004, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

ghost · 2023-01-03T18:31:11Z

🎉This issue was addressed in #5968, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

ghost · 2023-01-03T18:31:59Z

🎉This issue was addressed in #6138, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

ghost · 2023-01-03T18:32:23Z

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

A few small changes

a26b7e1

teaP requested a review from a team as a code owner August 28, 2019 22:38

jevansaks reviewed Aug 28, 2019

View reviewed changes

dev/TabView/TabView.xaml Show resolved Hide resolved

teaP force-pushed the user/teaP/TabViewSmallChanges branch from 1899d87 to a26b7e1 Compare August 29, 2019 17:07

jevansaks approved these changes Aug 29, 2019

View reviewed changes

Disable broken test

9c1ea91

teaP added the auto merge This PR will be merged once all checks pass label Aug 29, 2019

msft-github-bot merged commit 149f032 into master Aug 30, 2019

msft-github-bot deleted the user/teaP/TabViewSmallChanges branch August 30, 2019 18:01

DHowett-MSFT reviewed Sep 4, 2019

View reviewed changes

A few small changes #1234

A few small changes #1234

Conversation

teaP commented Aug 28, 2019

adrientetar commented Aug 28, 2019

jevansaks commented Aug 28, 2019

teaP commented Aug 29, 2019

jevansaks commented Aug 30, 2019

azure-pipelines bot commented Aug 30, 2019

DHowett-MSFT Sep 4, 2019

Choose a reason for hiding this comment

jevansaks Sep 4, 2019

Choose a reason for hiding this comment

teaP Sep 10, 2019

Choose a reason for hiding this comment

ghost commented Aug 17, 2021

ghost commented Aug 19, 2021

ghost commented Aug 20, 2021

ghost commented Aug 20, 2021

ghost commented Aug 20, 2021

ghost commented Aug 20, 2021

ghost commented Aug 20, 2021

ghost commented Jan 19, 2022

ghost commented Apr 14, 2022

ghost commented Apr 14, 2022

ghost commented Apr 14, 2022

ghost commented Apr 14, 2022

ghost commented Apr 14, 2022

ghost commented Apr 14, 2022

ghost commented Apr 14, 2022

ghost commented Jul 13, 2022

ghost commented Jul 13, 2022

ghost commented Jul 13, 2022

ghost commented Jul 13, 2022

ghost commented Jul 13, 2022

ghost commented Jul 13, 2022

ghost commented Jul 13, 2022

ghost commented Jul 13, 2022

ghost commented Jul 13, 2022

ghost commented Jul 18, 2022

ghost commented Jul 18, 2022

ghost commented Jul 18, 2022

ghost commented Jul 18, 2022

ghost commented Jul 18, 2022

ghost commented Jul 18, 2022

ghost commented Jul 18, 2022

ghost commented Jul 18, 2022

ghost commented Jul 18, 2022

ghost commented Aug 31, 2022

ghost commented Jan 3, 2023

ghost commented Jan 3, 2023

ghost commented Jan 3, 2023

ghost commented Jan 3, 2023

ghost commented Jan 3, 2023

ghost commented Jan 3, 2023

ghost commented Jan 3, 2023