IsPaneVisible doesn't actually hide the whole pane (just the content) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevansaks
reviewed
Dec 20, 2018
jevansaks
approved these changes
Dec 20, 2018
licanhua
reviewed
Dec 20, 2018
|
You will need to merge with master to pick up the Helix fix to get WinUI-Public-Tests working again. |
dbe08fc to
8ee6fcb
Compare
…t hiding the pane in left mode
… actually turn off the pane, not just the pane content
…itten in UpdateVisualStateForDisplayModeGroup.
8ee6fcb to
7ebe9db
Compare
|
🎉 Handy links: |
StephenLPeters
pushed a commit
that referenced
this pull request
Feb 9, 2019
…#114) * Add IsPaneVisible to repro issue with NavigationView.IsPaneVisible not hiding the pane in left mode * Drive some states based on whether the pane is visible so that we can actually turn off the pane, not just the pane content * Add a test (EnsurePaneCanBeHidden) that validates the fix * Move write of SplitView.DisplayMode out of the VSM since it's also written in UpdateVisualStateForDisplayModeGroup. * Add missing projects to the Debug_test configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binding here was targeting the root of the content hosted within the SplitView, but that's not the element that would need to be hidden to actually cause the whole pane to collapse. That node is owned by SplitView. SplitView doesn't offer any sort of succinct property to collapse the pane like what NavigationView's IsPaneVisible property tries to offer, but we can recreate the same effect by driving a couple of different SplitView properties.
This change drives a VSM for PaneVisible/PaneCollapsed and uses that to configure the SplitView.
Internal issue