Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The underline for NavigationViewItems in horizontal mode is too small (new UI) #4873

Closed
harvinders opened this issue Apr 21, 2021 · 8 comments
Labels
area-NavigationView NavView control area-UIDesign UI Design, styling no-issue-activity team-Controls Issue for the Controls team

Comments

@harvinders
Copy link

Describe the bug

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Create NavigationView with couple of items and set the mode to Horizontal
  2. The selected item is underlined
  3. The underline is too small and easy to miss

Expected behavior
Selected underline should cover the whole text

Version Info

NuGet package version:
[Microsoft.UI.Xaml.2.6.0-prerelease.210405001]

Windows app type:

UWP Win32
Yes
Windows 10 version Saw the problem?
Insider Build (xxxxx)
October 2020 Update (19042)
May 2020 Update (19041)
November 2019 Update (18363) Yes
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 21, 2021
@StephenLPeters StephenLPeters added area-NavigationView NavView control area-UIDesign UI Design, styling team-Controls Issue for the Controls team labels Apr 22, 2021
@StephenLPeters
Copy link
Contributor

@chigy FYI

@StephenLPeters
Copy link
Contributor

image

@karenbtlai FYI as well

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Apr 22, 2021
@karkarl
Copy link
Contributor

karkarl commented Apr 22, 2021

This is a design bug that I can definitely bring up with the design team.

@Shomnipotence
Copy link

image

@karenbtlai FYI as well

Amazing Design~~~~

@harvinders
Copy link
Author

harvinders commented Apr 23, 2021 via email

@rcohn
Copy link

rcohn commented Jan 18, 2022

Hi -

What is the status of this bug? I see the same short line (truncated line) behavior with the Microsoft.WindowsAppSDK 1.0 when trying to create a WinUI3 destop app using C++/Winrt. Is there a fix or workaround?

image

Here is the xaml:

<Window
    x:Class="DesktopCpp.MainWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:DesktopCpp"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    mc:Ignorable="d">

	<Grid>
		<Grid.RowDefinitions>
			<RowDefinition x:Name="navBarRow" Height="50"/>
			<RowDefinition x:Name="midRow" Height="*"/>
			<RowDefinition x:Name="quickBarHelpRow" Height="30"/>
		</Grid.RowDefinitions>

		<Grid.ColumnDefinitions>
			<ColumnDefinition x:Name="sideBarColumn" Width="200"/>
			<ColumnDefinition x:Name="mainContentAreaColumn" Width="*"/>
		</Grid.ColumnDefinitions>

		<NavigationView x:Name="navBarNavigationView" 
					Grid.Row="0" Grid.Column="0" Grid.ColumnSpan="2"
					IsBackButtonVisible="Collapsed"
					IsBackEnabled="False"
					IsSettingsVisible="False"
					PaneDisplayMode="Top"
					VerticalAlignment="Center">
			<NavigationView.MenuItems>
				<NavigationViewItem Tag="TestPage1" Content="Test Page 1"></NavigationViewItem>
				<NavigationViewItem Tag="TestPage2" Content="Test Page 2"></NavigationViewItem>
				<NavigationViewItem Tag="TestPage3" Content="Test Page 3"></NavigationViewItem>
			</NavigationView.MenuItems>
		</NavigationView>
	</Grid>
</Window>

I am at the point where I am seriously considering not using NavigationView in a desktop app. Trying to configure this control and stay current with Microsoft.WindowsAppSDK is not working.

Hopefully you can provide some guidance.

Thank you.

@chigy
Copy link
Member

chigy commented Jan 18, 2022

@harvinders , @rcohn ,
This is currently intended design. Our design team is aware of this feedback however is not something we are looking to modifying today.

@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control area-UIDesign UI Design, styling no-issue-activity team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

6 participants