Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling AutomationPeer.RaiseAutomationEvent and AutomationPeer.RaisePropertyChangedEvent does not seem to work #3469

Closed
marcelwgn opened this issue Oct 22, 2020 · 2 comments
Closed

Calling AutomationPeer.RaiseAutomationEvent and AutomationPeer.RaisePropertyChangedEvent does not seem to work #3469

marcelwgn opened this issue Oct 22, 2020 · 2 comments
Labels
area-Accessibility area-External Not owned by the WinUI team, not actionable in this repository. no-issue-activity

Comments

@marcelwgn
Copy link
Collaborator

Not sure if this is the correct repo for this, however WinUI is also affected by this. When implementing an AutomationPeer, raising the AutomationPeer.RaiseEvent function does not always seem to work and calling AutomationPeer.RaisePropertyChangedEvent does not trigger narrator announcing changes either. A good example of this is the NumberBox control which calls AutomationPeer.RaisePropertyChangedEvent here, however Narrator does not announce changes. This function get's called when user presses enter on the NumberBox control for example.
I am running insider build 20236, is it possible that this is just an issue with my insider build?

Also @YuliKl a question regarding testing, what settings for narrator should be used for testing narrator compatibility and behavior (e.g. level of context or level of detail)?
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 22, 2020
@ranjeshj ranjeshj added the accessibility Narrator, keyboarding, UIA, etc label Oct 22, 2020
@marcelwgn marcelwgn mentioned this issue Oct 23, 2020
Merged
6 tasks
@marcelwgn marcelwgn changed the title Calling AutomationPeer.RaiseEvent and AutomationPeer.RaisePropertyChangedEvent does not seem to work Calling AutomationPeer.RaiseAutomationEvent and AutomationPeer.RaisePropertyChangedEvent does not seem to work Oct 26, 2020
@ranjeshj ranjeshj added area-External Not owned by the WinUI team, not actionable in this repository. and removed needs-triage Issue needs to be triaged by the area owners labels Oct 27, 2020
@ranjeshj
Copy link
Contributor

This is an issue with the way Narrator understands what the control is providing. Tracked by an issue on the narrator side internally.

@marcelwgn marcelwgn mentioned this issue Oct 28, 2020
Closed
ghost pushed a commit to CommunityToolkit/WindowsCommunityToolkit that referenced this issue Oct 29, 2020
RadialGauge UIA improvements (#3544)
e3171b2 
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->

## Fixes #
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->

Fixes #3537 , Fixes #3539 , Fixes #3542 (this PR is all we can do, see microsoft/microsoft-ui-xaml#3469)

<!-- Add a brief overview here of the feature/bug & fix. -->

The issues with the sample were caused by microsoft/microsoft-ui-xaml#3467 , switching to RangeBaseAutomationPeer as base class for the RadialGauge peer fixes that.

Afaik, the only thing we can (and should do) for #3542 is raise the appropriate event on the AutomationPeer.

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

Bugfix
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

RadialGauge is not accessible

## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->

RadialGauge is accessible

## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [ ] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [x] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [x] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [Maybe?] Contains **NO** breaking changes

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
     Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->


## Other information

I left out the RangeSelector from this PR as fixing that controls behavior needs more discussion on how to approach that.
@YuliKl YuliKl added area-Accessibility and removed accessibility Narrator, keyboarding, UIA, etc labels Oct 30, 2020
@marcelwgn marcelwgn mentioned this issue Dec 7, 2020
Closed
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Accessibility area-External Not owned by the WinUI team, not actionable in this repository. no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@YuliKl @marcelwgn @ranjeshj