Fix LLM terminology in code #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced all occurrences of mlm_client and mlm_model with llm_client and llm_model for consistent terminology when referencing Large Language Models (LLMs).
|
@microsoft-github-policy-service agree [company="{AI}"] |
|
@microsoft-github-policy-service agree |
|
I agree with this, but changing this now will break things for people already experimenting with the library. Can we go in 2 steps. First let's enable the llm_ keywords as an alias to mlm_, and mark mlm_ as deprecated. Then we can remove mlm in a future release (e.g., 1 or two releases from now) |
|
@CharlesCNorton can you please resolve the conflicts. Also double check any other mentions of mlm e.g., in the README. [Update] Sorry I see the two PRs. I'll merge them together., |
gagb
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all occurrences of mlm_client and mlm_model with llm_client and llm_model for consistent terminology when referencing Large Language Models (LLMs).