Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLM terms #72

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Fix LLM terms #72

merged 5 commits into from
Dec 17, 2024

Conversation

CharlesCNorton
Copy link
Contributor

Updated all instances of mlm_client and mlm_model to llm_client and llm_model in the readme. The previous terms (mlm_client and mlm_model) are incorrect in the context of configuring Large Language Models (LLMs), as "MLM" typically refers to Masked Language Models, which is unrelated to the intended functionality. This change aligns the documentation with standard naming conventions for LLM configuration parameters and improves clarity for users integrating with LLMs like OpenAI's GPT models.

Updated all instances of mlm_client and mlm_model to llm_client and llm_model in the readme. The previous terms (mlm_client and mlm_model) are incorrect in the context of configuring Large Language Models (LLMs), as "MLM" typically refers to Masked Language Models, which is unrelated to the intended functionality. This change aligns the documentation with standard naming conventions for LLM configuration parameters and improves clarity for users integrating with LLMs like OpenAI's GPT models.
@afourney
Copy link
Member

afourney commented Dec 16, 2024

Indeed. This code dates back a while (to about the time of gpt-4-vision-preview), at which point it wasn't clear that to call the darned things, while making it clear the multimodality was necessary.

Anyhow: I agree with this, but changing this now will break things for people already experimenting with the library. Can we go in 2 steps. First let's enable the llm_ keywords as an alias to mlm_, and mark mlm_ as deprecated. Then we can remove mlm in a future release (e.g., 1 or two releases from now)

@gagb gagb merged commit c0127af into microsoft:main Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants