-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small type hint fixing + added makefile with couple commands. #49
Conversation
@microsoft-github-policy-service agree |
@jackgerrits do you think it makes sense to mix make files and pyproject.toml ? |
Related #46 |
Looks like this repo has no existing scripts or a system for defining scripts to run. A make file is totally reasonable and lightweight :) Can always be replaced if something like poe is used in future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@afourney are you okay with including a make file? |
Sure. If @jackgerrits says it's fine, I'll take that as gospel :) |
Given the simplicity of the makefile, personally I'd not add it to just keep the repo simple. But if it is helping someone then it's no harm |
Sorry @Abdujabbar, we appreciate your contributions though. |
Hello!
I've found some places where type hinting was missed, so I decided to fix these places and also added Makefile to simplify the command run.