Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small type hint fixing + added makefile with couple commands. #49

Closed
wants to merge 0 commits into from

Conversation

Abdujabbar
Copy link

Hello!

I've found some places where type hinting was missed, so I decided to fix these places and also added Makefile to simplify the command run.

@Abdujabbar
Copy link
Author

@microsoft-github-policy-service agree

@gagb gagb requested a review from jackgerrits December 16, 2024 23:43
@gagb
Copy link
Contributor

gagb commented Dec 16, 2024

@jackgerrits do you think it makes sense to mix make files and pyproject.toml ?

@gagb
Copy link
Contributor

gagb commented Dec 16, 2024

Related #46

@gagb gagb self-assigned this Dec 16, 2024
Makefile Outdated Show resolved Hide resolved
@jackgerrits
Copy link
Member

@jackgerrits do you think it makes sense to mix make files and pyproject.toml ?

Looks like this repo has no existing scripts or a system for defining scripts to run. A make file is totally reasonable and lightweight :) Can always be replaced if something like poe is used in future

Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gagb
Copy link
Contributor

gagb commented Dec 18, 2024

@afourney are you okay with including a make file?

@afourney
Copy link
Member

@afourney are you okay with including a make file?

Sure. If @jackgerrits says it's fine, I'll take that as gospel :)

@jackgerrits
Copy link
Member

@afourney are you okay with including a make file?

Sure. If @jackgerrits says it's fine, I'll take that as gospel :)

Given the simplicity of the makefile, personally I'd not add it to just keep the repo simple. But if it is helping someone then it's no harm

@gagb
Copy link
Contributor

gagb commented Dec 18, 2024

Sorry @Abdujabbar, we appreciate your contributions though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants