Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing if condition at line 1074 #65

Closed
Viddesh1 opened this issue Dec 16, 2024 · 1 comment
Closed

Removing if condition at line 1074 #65

Viddesh1 opened this issue Dec 16, 2024 · 1 comment

Comments

@Viddesh1
Copy link

def _append_ext(self, extensions, ext):
"""Append a unique non-None, non-empty extension to a list of extensions."""
if ext is None:
return
ext = ext.strip()
if ext == "":
return
# if ext not in extensions:
if True:
extensions.append(ext)

    def _append_ext(self, extensions, ext):
        """Append a unique non-None, non-empty extension to a list of extensions."""
        if ext is None:
            return
        ext = ext.strip()
        if ext == "":
            return
       
        extensions.append(ext)

Hello, I am new to this project. Thanks for creating it.

Rather that if condition at line number 1074 we can directly added the ext to extensions.

DIMAX99 added a commit to DIMAX99/markitdown that referenced this issue Dec 16, 2024
@afourney
Copy link
Member

Hah, good catch. Looks like line 1074 is some debug code. I will review the PR, asap.

gagb added a commit that referenced this issue Dec 17, 2024
@gagb gagb closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants