-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read container ID from event extended data #125
Read container ID from event extended data #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this! Added a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Added a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Please bump the versions in the the .nuspec files and we'll merge this in.
a002c06
to
89f1a48
Compare
Force push was a rebase to pull in the changes from the previous PR. |
This change should allow reading Windows container ID's from events coming from both Provider and RawProvider (from the managed API).
There's an extra #ifdef in extended_data_builder.hpp for compatibility with Windows SDK version 10.0.18362.0.
I will add nuspec version changes once it's clear what the version number should be.