Fix red color contrast for error messages (#147)

* Fix red color contrast for error messages The current red color is not contrasting enough in command prompt and powershell console. * Update test_log.py
microsoft · Apr 17, 2019 · 4ef3a1c · 4ef3a1c
1 parent c63836a
commit 4ef3a1c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/knack/log.py b/knack/log.py
@@ -45,8 +45,8 @@ def wrap_msg_with_color(msg):
                 return wrap_msg_with_color
 
             cls.COLOR_MAP = {
-                logging.CRITICAL: _color_wrapper(colorama.Fore.RED),
-                logging.ERROR: _color_wrapper(colorama.Fore.RED),
+                logging.CRITICAL: _color_wrapper(colorama.Fore.LIGHTRED_EX),
+                logging.ERROR: _color_wrapper(colorama.Fore.LIGHTRED_EX),
                 logging.WARNING: _color_wrapper(colorama.Fore.YELLOW),
                 logging.INFO: _color_wrapper(colorama.Fore.GREEN),
                 logging.DEBUG: _color_wrapper(colorama.Fore.CYAN)

diff --git a/tests/test_log.py b/tests/test_log.py
@@ -85,7 +85,7 @@ def test_get_module_logger(self):
 
 
 class TestCustomStreamHandler(unittest.TestCase):
-    expectation = {logging.CRITICAL: colorama.Fore.RED, logging.ERROR: colorama.Fore.RED,
+    expectation = {logging.CRITICAL: colorama.Fore.LIGHTRED_EX, logging.ERROR: colorama.Fore.LIGHTRED_EX,
                    logging.WARNING: colorama.Fore.YELLOW, logging.INFO: colorama.Fore.GREEN,
                    logging.DEBUG: colorama.Fore.CYAN}