Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update classname regex to not match leading numbers and special characters besides underscore #6188

Merged
merged 5 commits into from
Feb 24, 2025
Merged

fix: update classname regex to not match leading numbers and special characters besides underscore #6188

merged 5 commits into from
Feb 24, 2025

Conversation

Loag
Copy link
Contributor

@Loag Loag commented Feb 21, 2025 •
edited by baywet
Loading

fixes #6187

@Loag Loag requested a review from a team as a code owner February 21, 2025 17:48
@Loag
Copy link
Contributor Author

Loag commented Feb 21, 2025

@microsoft-github-policy-service agree

baywet
baywet requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

A minor comment.

Can you also update the changelog to ensure a rapid merge please? (unreleased, updated)

baywet
baywet approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge (squash) February 24, 2025 12:35
@baywet baywet merged commit 084f2cf into microsoft:main Feb 24, 2025
283 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

class-name parameter regex validator not catching hyphen
3 participants
@Loag @andrueastman @baywet