Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes integration tests on https://developers.pipedrive.com/docs/api/v1/openapi.yaml #4040

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fixes integration tests on https://developers.pipedrive.com/docs/api/v1/openapi.yaml #4040

merged 1 commit into from
Jan 23, 2024

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Jan 23, 2024 •
edited
Loading

This PR fixes #4028

Changes include :

  • Ensures the status code of a task is read and validated when executing the integration tests to prevent false positives.
  • Adds exclude pattern for tests on https://developers.pipedrive.com/docs/api/v1/openapi.yaml due to ambiguous paths causing tests failure.
  • Ensures exclude pattern parameters used in integration tests are also used in idempotency tests to ensure they build as well.
  • Updates typescript app.ts imports to prevent build error after changes in feature/request builders proxy #3938 changed the client from a class to interface.

@andrueastman andrueastman mentioned this pull request Jan 23, 2024
Closed
3 tasks
@andrueastman andrueastman changed the title Andrueastman/fix ci Fixes integration tests on https://developers.pipedrive.com/docs/api/v1/openapi.yaml Jan 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@andrueastman andrueastman marked this pull request as ready for review January 23, 2024 17:25
@andrueastman andrueastman requested a review from a team as a code owner January 23, 2024 17:25
baywet
baywet approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪💪💪💪

@andrueastman andrueastman merged commit ebdefca into main Jan 23, 2024
183 of 184 checks passed
@andrueastman andrueastman deleted the andrueastman/FixCI branch January 23, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intergration tests it/generate-code.ps1 does not fail if kiota generation fails.
2 participants
@andrueastman @baywet