Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Implements IAsyncParseNodeFactory interface #168

Merged
merged 5 commits into from
May 9, 2024
Merged

Implements IAsyncParseNodeFactory interface #168

merged 5 commits into from
May 9, 2024

Conversation

MihaMarkic
Copy link
Contributor

No description provided.

baywet
baywet suggested changes May 6, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this PR, it needs:

  • version bump (patch)
  • changelog entry (patch, tomorrow, changed)
  • updated reference to abstractions

baywet
baywet previously approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MihaMarkic is this good to merge from your perspective?

@baywet baywet marked this pull request as ready for review May 7, 2024 11:55
@baywet baywet requested a review from a team as a code owner May 7, 2024 11:55
@MihaMarkic
Copy link
Contributor Author

@baywet Added ConfigureAwait, now it's good.

@andrueastman andrueastman enabled auto-merge May 9, 2024 06:48
andrueastman
andrueastman approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution here

@andrueastman andrueastman merged commit d945e66 into microsoft:main May 9, 2024
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet left review comments

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MihaMarkic @andrueastman @baywet