Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Remove LINQ usage from Enum conversion from/to string #227

Merged
merged 3 commits into from
May 20, 2024

Conversation

filipnavara
Copy link
Contributor

This prevents unintended and unbound generic specialization expansion in the NativeAOT compiler.

Fixes #226

…unintended and unbound generic specialization expansion in the NativeAOT compiler.
@filipnavara filipnavara requested a review from a team as a code owner May 18, 2024 12:07
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @filipnavara

Any chance you can add a changelog entry in the repository root as well as bump the patch version in the csproj?

@filipnavara
Copy link
Contributor Author

Any chance you can add a changelog entry in the repository root

Yes

...as well as bump the patch version in the csproj?

Does it make sense to bump it since it is bumped to 1.3.0 which is still unreleased?

@filipnavara
Copy link
Contributor Author

Does it make sense to bump it since it is bumped to 1.3.0 which is still unreleased?

Ah, nevermind, it's actually on NuGet already.

@andrueastman andrueastman enabled auto-merge May 20, 2024 08:29
@andrueastman andrueastman merged commit 7074530 into microsoft:main May 20, 2024
7 checks passed
@am11
Copy link

am11 commented May 21, 2024

Great work @filipnavara, as always! 😎
In case you missed it, it is in 1.3.1 https://github.com/microsoft/kiota-serialization-json-dotnet/releases/tag/v1.3.1. 🚀

@filipnavara
Copy link
Contributor Author

Great work @filipnavara, as always! 😎
In case you missed it, it is in 1.3.1 https://github.com/microsoft/kiota-serialization-json-dotnet/releases/tag/v1.3.1. 🚀

Thanks! Already compiling with it. Let's see how far I can push the limits on the next attempt with our app :)

@filipnavara filipnavara deleted the enum-aot branch May 21, 2024 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unbounded LINQ expansion in AOT scenarios
3 participants