Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono-repo updates for release #174

Merged
merged 22 commits into from
Feb 10, 2025
Merged

Conversation

microsoft-graph-devx-bot[bot]
Copy link
Contributor

This PR contains updates from the kiota-php monorepo. Merging these changes will trigger Release-Please on this repository.

@microsoft-graph-devx-bot microsoft-graph-devx-bot bot requested a review from a team as a code owner February 10, 2025 17:59
@microsoft-graph-devx-bot microsoft-graph-devx-bot bot merged commit c4dcf13 into main Feb 10, 2025
11 checks passed
@baywet baywet deleted the release/abstractions branch February 10, 2025 18:16
@baywet
Copy link
Member

baywet commented Feb 10, 2025

@Ndiritu I'm only approving one to understand the new workflow.
Who/what is supposed to create the tag here?

@Ndiritu
Copy link
Contributor

Ndiritu commented Feb 11, 2025

@Ndiritu I'm only approving one to understand the new workflow. Who/what is supposed to create the tag here?

@baywet I initially intended for Release-Please to do the tagging, but this probably failed because the release-please-manifest version was not bumped & now conflicts with the release-as version in the release-please-config. Either way this seems like it would introduce double the number of PRs to merge across all the repos: Mono-repo updates like this one + another release please PR that triggers tagging & GH release.

I'm thinking introducing a GitHub workflow that auto-merges PRs like this & creates a tag + GH release would be more efficient.

Also considering that we'll always have to release abstractions first so that the other package's build workflows don't fail, the other package workflows can do some limited retry in installing dependencies for their auto-merge & tagging workflows to run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

2 participants