Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reduntant method calling #439

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Remove reduntant method calling #439

merged 1 commit into from
Apr 26, 2024

Conversation

marcominerva
Copy link
Contributor

Motivation and Context (Why the change? What's the scenario?)

In the following method:

public static IKernelMemoryBuilder WithAzureQueuesOrchestration(this IKernelMemoryBuilder builder, AzureQueuesConfig config)
{
config.Validate();
builder.Services.AddAzureQueuesOrchestration(config);
return builder;
}
}

There is a call to the AzureQueuesConfig.Validate method, but then the AddAzureQueuesOrchestration method is invoked, that in turns calls AzureQueuesConfig.Validate again:

So, it is possible to safely remove the first invocation.

@marcominerva marcominerva requested a review from dluc as a code owner April 26, 2024 09:50
@dluc dluc merged commit 4598fb2 into microsoft:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants