Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreverse prompts and introduce relevance option (not hardcoded) #28

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Unreverse prompts and introduce relevance option (not hardcoded) #28

merged 5 commits into from
Aug 23, 2023

Conversation

crickman
Copy link
Contributor

@crickman crickman commented Aug 23, 2023 •
edited
Loading

Motivation and Context (Why the change? What's the scenario?)

  • Prompts got shuffled up in all the code moves.
  • Customers changing relevancy setting as they experiment with sandbox

High level description (Approach, Design)

  • Unreverse prompts
  • Make relevancy a configurable option (not hardcoded): MinSchemaRelevance

@crickman crickman linked an issue Aug 23, 2023 that may be closed by this pull request
Sample 008-dotnet-nl2sql Issues #25
Closed
@crickman crickman requested a review from dluc August 23, 2023 19:44
@crickman crickman self-assigned this Aug 23, 2023
@crickman crickman added bug Something isn't working sample labels Aug 23, 2023
@crickman crickman mentioned this pull request Aug 23, 2023
Closed
@dluc dluc merged commit b995086 into main Aug 23, 2023
@dluc dluc deleted the fix-prompt-and-relevancy branch August 23, 2023 20:15
@kill136 kill136 mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dluc dluc dluc approved these changes

Assignees

@crickman crickman

Labels
bug Something isn't working sample
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample 008-dotnet-nl2sql Issues
2 participants
@crickman @dluc