Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Valgrind build and test to CI pipeline #95

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

erik0686
Copy link
Contributor

@erik0686 erik0686 commented Apr 14, 2021

Summary

This PR adds the necessary steps to run Valgrind on PR's made to this repo.
Worth mentioning that unlike upstream ICU, where valgrind is run on batches of PR's, we will run it for every PR made here :)

PR Checklist

  • I have verified that my change is specific to this fork and cannot be made upstream.
  • I am making a maintenance related change.
  • I am making a change that is related to usage internal to Microsoft.
  • I am making a change that is related to the Windows OS build of ICU.
  • CLA signed. If not, please see here to sign the CLA.

Detailed Description

Copy link
Member

@jefgen jefgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this! :)

@jefgen jefgen changed the title add valgrind job to pipeline Add Valgrind build and test to CI pipeline Apr 14, 2021
@jefgen
Copy link
Member

jefgen commented Apr 14, 2021

Note: Please use a squash merge if you merge this PR.

@erik0686 erik0686 merged commit 51ff31a into master Apr 14, 2021
@jefgen jefgen deleted the user/ertorres/add-valgrind branch August 3, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants