Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GooglePlayPromote] Migrated to Node10 #224

Merged
merged 4 commits into from
Feb 4, 2021
Merged

[GooglePlayPromote] Migrated to Node10 #224

merged 4 commits into from
Feb 4, 2021

Conversation

sdobrodeev
Copy link

@sdobrodeev sdobrodeev commented Jan 25, 2021 •
edited
Loading

Task name: google-play-promote

Description: Migrated task to Node 10.

Documentation changes required: No

Added unit tests: No

Attached related issue: No

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@sdobrodeev sdobrodeev requested a review from a team January 25, 2021 09:10
@sdobrodeev sdobrodeev self-assigned this Jan 25, 2021
@anatolybolshakov
Copy link
Contributor

Let's make buddy testing before we merge it

@anatolybolshakov anatolybolshakov requested a review from a team January 27, 2021 12:56
@egor-bryzgalov
Copy link
Member

Tested manually.

@sdobrodeev
Copy link
Author

Tested manually. No issues found.

@sdobrodeev sdobrodeev merged commit 3f10679 into master Feb 4, 2021
@sdobrodeev sdobrodeev deleted the users/sdobrodeev/google-play-promote-node10-migration branch February 4, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-bryzgalov egor-bryzgalov egor-bryzgalov left review comments

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@DaniilShmelev DaniilShmelev DaniilShmelev approved these changes

Assignees

@sdobrodeev sdobrodeev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdobrodeev @anatolybolshakov @egor-bryzgalov @DaniilShmelev