Fix single-feed error with Release Studio nuget.config #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
approved these changes
Feb 11, 2025
dagood
added a commit
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 376cd32)
This actually didn't block 1.22+1.23 because they don't include macOS. 1.24 would be blocked. |
dagood
added a commit
that referenced
this pull request
Feb 12, 2025
(cherry picked from commit 376cd32)
dagood
added a commit
that referenced
this pull request
Feb 12, 2025
(cherry picked from commit 376cd32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this issue in our main and release builds after #1528. (Ex.) It turns out that using multiple feeds in this situation is a problem. (See comments.) Fix it by removing the feed and using a workaround.
I didn't catch it because the multi-feed detector is only working on our macOS agents. (We don't use a shallow checkout there, and shallow checkout seems to cause a silent detector failure on all our other stages.) I had only internally tested that #1528 didn't break our publish stages.
I'll need to backport this fix to the release branches.
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2640418&view=results
I'd considered this
BundledNETCoreAppTargetFrameworkVersionworkaround earlier, but didn't apply it at first because it seemed like the simpler fix of using multiple feeds was working. I'm not the first person to think of it, though: