Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule to latest master in microsoft/main #1095

Closed

Conversation

microsoft-golang-bot
Copy link
Collaborator

Hi! I'm a bot, and this is an automatically generated upstream sync PR. 🔃

After submitting the PR, I will attempt to enable auto-merge in the "merge commit" configuration.

For more information, visit sync documentation in microsoft/go-infra.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Auto-approving.

@dagood
Copy link
Member

dagood commented Dec 20, 2023

Removed our patch to allow TLS 1.3 in tls fipsonly mode, implemented in upstream as of:

549975: crypto/tls: align FIPS-only mode with BoringSSL policy | https://go-review.googlesource.com/c/go/+/549975

The patch conflicted in a few places and not others. I'm double-checking now but it seems to have the same result although some bits have been moved around. /cc @qmuntal @gdams

@dagood
Copy link
Member

dagood commented Dec 20, 2023

The build now fails because that CL also adds a new crypto function to handle:

func NewGCMTLS13(cipher.Block) (cipher.AEAD, error) { panic("boringcrypto: not available") }

@dagood dagood force-pushed the dev/auto-sync/microsoft/main branch from f30e708 to 1f5eb26 Compare December 22, 2023 19:28
@dagood dagood closed this Dec 22, 2023
auto-merge was automatically disabled December 22, 2023 20:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants