Skip to content

Commit

Permalink
Upgrade Go bootstrap version to go1.24.0-1 (#1562)
Browse files Browse the repository at this point in the history
* upgrade Go bootstrap version to go1.24.0-1

* pass -AzurePipelinePath to go-install.ps1

* don't set MS_USE_PATH_GO
  • Loading branch information
qmuntal authored Feb 13, 2025
1 parent 935605b commit 423691a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 16 deletions.
19 changes: 4 additions & 15 deletions eng/pipeline/stages/run-stage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,6 @@ stages:
- name: MS_GO_UTIL_ALLOW_ONLY_MINIMAL_DEPS
value: '1'

# On darwin (macOS) we haven't released a Microsoft build Go toolchain.
- ${{ if eq(parameters.builder.os, 'darwin') }}:
- name: MS_USE_PATH_GO
value: '1'

- ${{ if eq(parameters.builder.config, 'codeql_inner') }}:
# Manually specify the repository being scanned by this job because
# CodeQL can't detect the inner repository (the submodule)
Expand Down Expand Up @@ -148,16 +143,10 @@ stages:
# Initialize stage 0 toolset ahead of time so we can track timing data separately from the
# build operations. When we call this script again later, it won't download Go again.
- ${{ if eq(parameters.builder.os, 'darwin') }}:
- task: GoTool@0
inputs:
version: '1.23.3'
displayName: Init upstream stage 0 Go toolset
- ${{ else }}:
- pwsh: |
. eng/utilities.ps1
Download-Stage0
displayName: Init stage 0 Go toolset
- pwsh: |
. eng/utilities.ps1
Download-Stage0
displayName: Init stage 0 Go toolset
- template: ../steps/init-submodule-task.yml

Expand Down
2 changes: 1 addition & 1 deletion eng/utilities.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function Download-Stage0() {
# pre-installed (or the right version pre-installed). This CI script installs a consistent version
# of Go to handle this. This also makes it easier to locally repro issues in CI that involve a
# specific version of Go. The downloaded copy of Go is called the "stage 0" version.
$stage0_go_version = 'go1.23.3-1'
$stage0_go_version = 'go1.24.0-1'

# Source the install script so that we can use the PATH it assigns.
$installScriptPath = Join-Path $PSScriptRoot "_util" "go-install.ps1"
Expand Down

0 comments on commit 423691a

Please sign in to comment.