Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update azidentity to 1.2.1 #90

Merged
merged 4 commits into from
Feb 28, 2023
Merged

update azidentity to 1.2.1 #90

merged 4 commits into from
Feb 28, 2023

Conversation

gambtho
Copy link

@gambtho gambtho commented Feb 21, 2023

Update to azidentity dependency to 1.21, includes in memory cache of managed identity credential (introduced in 1.2.0) and msal update. https://github.com/Azure/azure-sdk-for-go/releases/tag/sdk%2Fazidentity%2Fv1.2.1

Copy link

@imiller31 imiller31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shueybubbles
Copy link
Collaborator

please update CHANGELOG in the root

CHANGELOG.md Outdated
@@ -10,6 +10,7 @@
wrapped, and can be detected by using errors.As/Is practise. This connection
errors can, and could even before, happen anytime the sql.DB doesn't have free
connection for executed query.
* Updated azidentity to 1.2.1, which adds in memory cache for managed credentials
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.20.0 already went out, add a 0.21.0 entry
We don't have automation of this file content (yet).

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #90 (2075049) into main (f481f92) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   74.64%   74.53%   -0.11%     
==========================================
  Files          29       29              
  Lines        5592     5592              
==========================================
- Hits         4174     4168       -6     
- Misses       1175     1179       +4     
- Partials      243      245       +2     
Impacted Files Coverage Δ
tds.go 72.24% <0.00%> (-0.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gambtho gambtho merged commit c375dfd into main Feb 28, 2023
@gambtho gambtho deleted the thgamble/azidentity1-20 branch February 28, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants