Fix: handle float32 according to spec in all cases #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 74.79% 74.74% -0.05%
==========================================
Files 32 32
Lines 6379 6379
==========================================
- Hits 4771 4768 -3
- Misses 1325 1327 +2
- Partials 283 284 +1 ☔ View full report in Codecov by Sentry. |
|
@CL-Jeremy if you want to finish the change, just include the test update as part of this same PR. No need for separate changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered what looks quite similar to the issue submitter's case, so I replied in that issue and did a follow-up there: uptrace/bun#993 (comment).
According to the spec (https://pkg.go.dev/database/sql#Scanner), single-precision float values must always be returned as doubles, which could then be downcasted to recover the original value (leaving the binary representation unchanged, so there is no loss of precision if handled properly).
This bug is only present in
readFixedType, so it seems to be due to carelessness.