Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: change clickable spans to buttons #3741

Merged
merged 5 commits into from
Jan 20, 2018
Merged

Calendar: change clickable spans to buttons #3741

merged 5 commits into from
Jan 20, 2018

Conversation

jordandrako
Copy link
Contributor

@jordandrako jordandrako commented Jan 18, 2018 •
edited
Loading

Pull request checklist

Description of changes

Change all calendar spans with onClick to buttons. Add CSS properties to related classes to reset browser default button styles.

Focus areas to test

Be sure added CSS doesn't have ill effects on all supported browsers.

@msftclas
Copy link

msftclas commented Jan 18, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@jordandrako jordandrako changed the title #1535 calendar change clickable spans Calendar: change clickable spans Jan 18, 2018
@jordandrako jordandrako changed the title Calendar: change clickable spans Calendar: change clickable spans to buttons Jan 18, 2018
@jordandrako
Copy link
Contributor Author

I'm concerned there may be scalability issues using background: transparent; and the likes. Should I try using an existing variable, or add a className instead?

@gokunymbus
Copy link
Contributor

All these changes look great, thank you! 👍 . @jordandrako let's track that discussion outside of GitHub and complete this pull request.

@gokunymbus gokunymbus self-requested a review January 19, 2018 05:41
gokunymbus
gokunymbus approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@gokunymbus gokunymbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@gokunymbus
Copy link
Contributor

gokunymbus commented Jan 19, 2018 •
edited
Loading

@jordandrako it looks like you have a breaking build because the jest test for Calendar is breaking. This is expected because you changed the spans to buttons and now the snapshots no longer match. Within packages/office-ui-fabric-react/ you can run npm run update-snapshots, commit/push the update and the build should pass.

Once it does you you are free to merge this code in.

@johannao76
Copy link
Collaborator

johannao76 commented Jan 19, 2018 via email

@lorejoh12
Copy link
Contributor

confirmed that calendar still looks fine, thanks for making this change!

@lorejoh12 lorejoh12 merged commit fd2206f into microsoft:master Jan 20, 2018
chrismohr pushed a commit to chrismohr/office-ui-fabric-react that referenced this pull request Apr 17, 2018
@jordandrako
Calendar: change clickable spans to buttons (microsoft#3741)
6c0a761 
* Change clickable spans to buttons.

* Add button resets to classes used by buttons that were spans

* npm run changes output

* Correct email to microsoft alias

* Update snapshot
@KevinTCoughlin KevinTCoughlin mentioned this pull request Apr 24, 2018
Merged
2 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gokunymbus gokunymbus gokunymbus approved these changes

@lorejoh12 lorejoh12 lorejoh12 approved these changes

@johannao76 johannao76 Awaiting requested review from johannao76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calendar: use buttons rather than clickable spans for days/months
5 participants
@jordandrako @msftclas @gokunymbus @johannao76 @lorejoh12