fix(vr-tests-react-components): migrate to new StoryWright api to define Steps to resolve VR snapshoting issues #33860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricteam
reviewed
Feb 18, 2025
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
fabricteam
reviewed
Feb 18, 2025
8eeaeea to
ca3f5ac
Compare
5c15be6 to
de5ffad
Compare
…ine Steps to resolve VR snapshoting issues
4a90a20 to
15438b9
Compare
🕵 FluentUIV0 No visual regressions between this PR and main |
🕵 fluentuiv8 No visual regressions between this PR and main |
Hotell
commented
Feb 27, 2025
| @@ -11,7 +11,7 @@ | |||
| "start": "storybook dev", | |||
| "test": "just-scripts test", | |||
| "type-check": "tsc -p . --noEmit --baseUrl .", | |||
| "test-vr": "storywright --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true" | |||
| "test-vr": "storywright --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true --bailOnStoriesError" | |||
There was a problem hiding this comment.
new functionality that we shipped to SW, now if there will be any issues within our VR tests pipeline will fail ! 💪
Hotell
commented
Feb 27, 2025
| /** Helper function that returns RTL, Dark Mode or High Contrast variant of an existing story. */ | ||
| export function getStoryVariant(story: StoryFn, variant: StoryVariant) { | ||
| export function getStoryVariant(story: StoryFn | StoryObj, variant: StoryVariant): StoryObjVariant { |
There was a problem hiding this comment.
improved types that reflect the actual usage ( we support both CSF2 and CSF3 🥹 )
Hotell
commented
Feb 27, 2025
| * | ||
| * @deprecated - set Steps via Story.parameters.storyWright API | ||
| * This throws error if griffel `makeStyles` apis are used to tweak story rendering | ||
| */ |
There was a problem hiding this comment.
there are still 119 occurences of this API - will be refactored later on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Steps object is undefined (v9)errors occurred while processing Stories to obtain Steps definitions:VR tests count (v9)making screenshots pass rateRelated Issue(s)
makeStylesapi is used directly for story rendering #33861