Revert "fix(react-utilities): click scrollbar should invoke callback in useOnClickOutside"
#29065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 19 | 10 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 632 | 610 | 5000 | |
| Button | mount | 322 | 318 | 5000 | |
| Field | mount | 1099 | 1134 | 5000 | |
| FluentProvider | mount | 720 | 720 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 94 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 83 | 92 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 85 | 92 | 10 | |
| InfoButton | mount | 19 | 10 | 5000 | Possible regression |
| MakeStyles | mount | 876 | 876 | 50000 | |
| Persona | mount | 1760 | 1737 | 5000 | |
| SpinButton | mount | 1349 | 1371 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aa5011e:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 94019033dfe3fd39ec0cde7dfb3b57c22805aa91 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #28965 as it causes another issue:
In macOS, for popover with
openOnContext, right click on the trigger, notice the popover is opened. Keep the mouse pressed, move the mouse outside and then mouseUp, notice the popover is closed, but the expected behavior is staying open.The above happens because #28965 changes from listening to click/contextMenu event to listening to mouseUp event. On context menu click in macOS, events are mouseDown -> contextMenu -> mouseUp (unlike left click where click fires after mouseUp). Therefore the below happens when right click:
useOnClickOutsideattach mouseDown event listener that checks if mouseDown happens inside. And a mouseUp event listener that closes popover if mouseDown wasn't inside.The same issue doesn't happen in windows because in windows events are mouseDown -> mouseUp -> contextMenu (similar as left click). Therefore the below happens:
useOnClickOutsideattach mouseDown/mouseUp event listener. And popover stays open. ✅Here's a minimal repro https://codesandbox.io/s/nifty-ben-6734vt?file=/src/App.js notice on macOS it logs both mouseUp and contextMenu event, while on windows it logs only contextMenu event.
It is tricky to fix this issue because the inconsistency comes from OS ((mozilla/geckodriver#1201). Therefore this PR reverts the original PR that causes this issue, as close on clicking scrollbar has never worked in v0. Plus there's an on going PR to close popover on dragging scrollbar.