Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more content to Breadcrumb Readme and replaced MenuItem #28626

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Added more content to Breadcrumb Readme and replaced MenuItem #28626

merged 4 commits into from
Jul 25, 2023

Conversation

ValentinaKozlova
Copy link
Contributor

Previous Behavior

  • MenuItem was used for overflow logic in BreadcrumbLink component

New Behavior

  • There's new feature in Menu - MenuItemLink. I replaced it for BreadcrumbLink with overflow
  • Added more content to the Readme

@ValentinaKozlova ValentinaKozlova self-assigned this Jul 24, 2023
@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review July 24, 2023 15:15
@ValentinaKozlova ValentinaKozlova requested a review from a team as a code owner July 24, 2023 15:15
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 24, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against d8493a92520cacac29e9fe341a17d3595bc48343

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 24, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca9371d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 24, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c017e880f238c1f113ff7ff6e28560d77e7ea46b (build)

@ValentinaKozlova ValentinaKozlova merged commit e7e522f into microsoft:master Jul 25, 2023
@ValentinaKozlova ValentinaKozlova deleted the fix/breadcrumb-readme branch July 25, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees

@ValentinaKozlova ValentinaKozlova

Labels
Component: Breadcrumb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValentinaKozlova @fabricteam @marcosmoura