Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-tags: fill icon on hover for outlined InteractionTag #28558

Merged
merged 2 commits into from
Jul 19, 2023
Merged

react-tags: fill icon on hover for outlined InteractionTag #28558

merged 2 commits into from
Jul 19, 2023

Conversation

YuanboXue-Amber
Copy link
Contributor

@YuanboXue-Amber YuanboXue-Amber commented Jul 18, 2023 •
edited
Loading

  1. fill icon on hover for InteractionTag outlined variant:
image
  1. update react-tag stories to use the same icon

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review July 18, 2023 10:18
@YuanboXue-Amber YuanboXue-Amber requested review from a team as code owners July 18, 2023 10:18
@size-auditor
Copy link

size-auditor bot commented Jul 18, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: dd42cd31e7a82e7eecf801f59a03cdf1d758c73d (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2023 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-tags-preview
InteractionTag		 33.855 kB
9.08 kB		 34.145 kB
9.188 kB		 290 B
108 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-tags-preview
Tag		 25.936 kB
8.483 kB
react-tags-preview
TagGroup		 69.142 kB
20.294 kB
🤖 This report was generated against dd42cd31e7a82e7eecf801f59a03cdf1d758c73d

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 18, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca02195:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@YuanboXue-Amber YuanboXue-Amber enabled auto-merge (squash) July 19, 2023 08:40
@YuanboXue-Amber YuanboXue-Amber merged commit def3c87 into microsoft:master Jul 19, 2023
@YuanboXue-Amber YuanboXue-Amber deleted the tag-fill branch July 19, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanboXue-Amber @fabricteam @ling1726