fix(PortalCompatProvider): support custom ID prefixes in themeClassName #28551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changes
Baseline commit: beef7217f6b332ce3339e81d5448135d9142c495 (build) |
📊 Bundle size report
🤖 This report was generated against beef7217f6b332ce3339e81d5448135d9142c495 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1562100:
|
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When a custom ID prefix is set via
IdPrefixProvider, the resulting theme class name is not picked up byPortalCompatProviderand so v9 CSS variables are not available in v8 portals. This is due the current regex in the component that only picks upfui-FluentProviderXXXpart and not a possible prefix.New Behavior
A regex that is used to pick a class name from a list of class names in
themeClassNameis updated to include a prefix into a caption group if the prefix exists.Related Issue(s)