Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): implement react-library generator #28550

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 17, 2023

Previous Behavior

  • we use plop for bootstraping new react v9 packages
  • no --help
  • no option to pass positionals directly form CLI
  • no option to run it in dry run mode
  • no test coverage

Example of "help"

image

New Behavior

We have nx generator to bootstrap v9 react library, which provides superb DX in comparison with old create-package command.

DEMO:

yarn nx workspace-generator react-library
image

ADDITIONAL NOTES:

A follow up PR will replace create-package npm script aliase to invoke nx generator

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 17, 2023

📊 Bundle size report

🤖 This report was generated against 4ba8f4fa6fb612fffc61b9911851b21d8728d9f0

@size-auditor
Copy link

size-auditor bot commented Jul 17, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4ba8f4fa6fb612fffc61b9911851b21d8728d9f0 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ae24a19:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@Hotell Hotell force-pushed the hotell/nx/generators/react-library branch from 236b152 to 8081248 Compare July 18, 2023 07:58
@Hotell Hotell changed the title Hotell/nx/generators/react library feat(tools): implement react-library generator Jul 18, 2023
@Hotell Hotell marked this pull request as ready for review July 18, 2023 10:54
@Hotell Hotell requested a review from a team as a code owner July 18, 2023 10:54
@Hotell Hotell force-pushed the hotell/nx/generators/react-library branch from bfc659f to 13d9247 Compare July 18, 2023 10:56
@tudorpopams tudorpopams self-requested a review July 18, 2023 12:21
@Hotell Hotell merged commit c3819e5 into microsoft:master Jul 19, 2023
@Hotell Hotell deleted the hotell/nx/generators/react-library branch July 19, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants