Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating status bar values #28440

Merged
merged 8 commits into from
Jul 18, 2023
Merged

Conversation

Jacqueline-ms
Copy link
Contributor

@Jacqueline-ms Jacqueline-ms commented Jul 5, 2023

Semantic name clean up and mapping for status bar

Icons:

image

Backgrounds:

image

Data viz colors

image

All Data and Status Semantic Names in Light Theme:

dataColor1: "#0078D4"
dataColor2: "#EF6950"
dataColor3: "#00188F"
dataColor4: "#00A2AD"
dataColor5: "#4B003F"
dataColor6: "#E3008C"
dataColor7: "#022F22"
dataColor8: "#917EDB"
dataColor9: "#001D3F"
dataColor10: "#502006"
noData2Color: "#747474"
noDataColor1: "rgba(128, 128, 128, .70)"
statusDefaultBackground: "#F0F6FF"
statusDefaultBorder: "#F0F6FF"
statusDisabledIcon: "#8A8886"
statusErrorBackground: "#FEF0F1"
statusErrorBorder: "#FEF0F1"
statusErrorIcon: "#a4262c"
statusErrorText: "#292827"
statusInformationBackground: "#F0F6FF"
statusInformationIcon: "#015cda"
statusInformationText: "#292827"
statusLink: "#005A9E"
statusLinkHover: "#4578"
statusSuccessBackground: "#F8FFF0"
statusSuccessBorder: "#F8FFF0"
statusSuccessIcon: "#57A300"
statusSuccessText: "#292827"
statusUpsellBackground: "#F9F3FC"
statusUpsellIcon: "#8a2da5"
statusWarningBackground: "#FFF8F0"
statusWarningBorder: "#FFF8F0"
statusWarningIcon: "#DB7500"
statusWarningText: "#292827"

All Data and Status Semantic Names in Dark Theme:

dataColor1: "#0078D4"
dataColor2: "#CB4936"
dataColor3: "#BEDFFF"
dataColor4: "#038387"
dataColor5: "#F6C0FF"
dataColor6: "#D90086"
dataColor7: "#A4E1D2"
dataColor8: "#6E5DB7"
dataColor9: "#C7D3FF"
dataColor10: "#FFCA8A"
noData2Color: "#747474"
noDataColor1: "rgba(128, 128, 128, .70)"
statusDefaultBackground: "#00245B"
statusDefaultBorder: "#00245B"
statusDisabledIcon: "#8A8886"
statusErrorBackground: "#442726"
statusErrorBorder: "#442726"
statusErrorIcon: "#e00b1c"
statusInformationBackground: "#00245B"
statusInformationIcon: "#015cda"
statusInformationText: "#F3F2F1"
statusLink: "#6cb8f6"
statusLinkHover: "#82C7FF"
statusSuccessBackground: "#393D1B"
statusSuccessBorder: "#393D1B"
statusSuccessIcon: "#57A300"
statusSuccessText: "#F3F2F1"
statusUpsellBackground: "#38134A"
statusUpsellIcon: "#8a2da5"
statusWarningBackground: "#4F2A0F"
statusWarningBorder: "#4F2A0F"
statusWarningIcon: "#DB7500"
statusWarningText: "#F3F2F1"

Notes

Light semantic names listed here are the same in high contrast light, and dark semantic names are the same in high contrast dark.
NoData1 and NoData2 is the same in all 4 subthemes

Maintained status bar styles

image

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 5, 2023

📊 Bundle size report

🤖 This report was generated against 3cbeb7ed15c56a8eee665e5d404c005f01d7c94a

@size-auditor
Copy link

size-auditor bot commented Jul 5, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3cbeb7ed15c56a8eee665e5d404c005f01d7c94a (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c6d66a9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@Jacqueline-ms Jacqueline-ms marked this pull request as ready for review July 10, 2023 21:04
@Jacqueline-ms
Copy link
Contributor Author

@robtaft-ms ready for review when you are :)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Copy link

@robtaft-ms robtaft-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much!

@Jacqueline-ms Jacqueline-ms merged commit 8a242b1 into master Jul 18, 2023
@Jacqueline-ms Jacqueline-ms deleted the jackieg/azuretheme-messagebarstatus branch July 25, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants