chore: update the appearance filled styles on text-field, text-area and number-field components #17595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6eda29:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e45eeaba8deb93e825a9d3f72e87a9c4c9225ea1 (build) |
57dbbf6 to
4b001cc
Compare
|
@khamudom Is this aligned with the latest versions of Fluent outlined in the specs? Just trying to get a feel for whether this is catch-up to the old versions or part of the new work. |
Correct, this is aligning to the latest fluent design. |
EisenbergEffect
approved these changes
Mar 30, 2021
bheston
approved these changes
Mar 30, 2021
chrisdholt
approved these changes
Mar 31, 2021
|
🎉 Handy links: |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…nd number-field components (microsoft#17595) * update filled style on textfield textarea and numberfield * Change files * update high contrast color on placeholder and label * create and input pattern file and applied pattern to filled inputs * fix import order * updated api-report * adding transition to active line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
The updated style involves adding the active state for text-field text-area and number-filed, the active state has a small underline and when focused the underline fills the width of the input.
Created a file in the patterns directory called
input.ts. This is where we will put different helper styles for the different types of input appearance. Currently, the only helper object is for thefilledappearance.Additional changes were in the text-area component, where the display was changed to inline-flex, this removes an extra space that was being set on the bottom of the component.
High contrast style was also addressed to match the updated design.
text-field (rest, hover, active and focus)
text-area (rest, hover, active and focus)
number-field (rest, hover, active and focus)
High Contrast (active and focus states)
Focus areas to test
(optional)