Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes broken rtl scenerio #16247

Merged
merged 18 commits into from
Dec 17, 2020
Merged

Conversation

eljefe223
Copy link
Contributor

@eljefe223 eljefe223 commented Dec 16, 2020

Pull request checklist

This PR fixes broken rtl scenario specifically in switch and tree-item.

image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 640ec4c:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 859 840 5000
BaseButtonCompat mount 983 972 5000
Breadcrumb mount 42462 43048 5000
Checkbox mount 1584 1581 5000
CheckboxBase mount 1268 1307 5000
ChoiceGroup mount 4935 4803 5000
ComboBox mount 1004 1056 1000
CommandBar mount 10113 10263 1000
ContextualMenu mount 6083 6129 1000
DefaultButtonCompat mount 1175 1175 5000
DetailsRow mount 3833 3797 5000
DetailsRowFast mount 3796 3841 5000
DetailsRowNoStyles mount 3605 3641 5000
Dialog mount 1533 1506 1000
DocumentCardTitle mount 1775 1787 1000
Dropdown mount 3479 3459 5000
FocusTrapZone mount 1794 1900 5000
FocusZone mount 1828 1880 5000
IconButtonCompat mount 1886 1834 5000
Label mount 340 337 5000
Layer mount 1889 1900 5000
Link mount 500 502 5000
MenuButtonCompat mount 1541 1579 5000
MessageBar mount 2148 2094 5000
Nav mount 3478 3459 1000
OverflowSet mount 1100 1058 5000
Panel mount 1445 1453 1000
Persona mount 872 913 1000
Pivot mount 1495 1451 1000
PrimaryButtonCompat mount 1358 1319 5000
Rating mount 8236 8007 5000
SearchBox mount 1389 1398 5000
Shimmer mount 2710 2732 5000
Slider mount 1993 1995 5000
SpinButton mount 5215 5144 5000
Spinner mount 444 422 5000
SplitButtonCompat mount 3321 3297 5000
Stack mount 531 541 5000
StackWithIntrinsicChildren mount 1655 1711 5000
StackWithTextChildren mount 4951 4872 5000
SwatchColorPicker mount 10781 10534 5000
Tabs mount 1410 1459 1000
TagPicker mount 2988 3066 5000
TeachingBubble mount 11951 12073 5000
Text mount 453 429 5000
TextField mount 1471 1471 5000
ThemeProvider mount 2151 2152 5000
ThemeProvider virtual-rerender 653 654 5000
Toggle mount 839 823 5000
button mount 704 733 5000
buttonNative mount 117 108 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.48 0.51 0.94:1 2000 965
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 634
🔧 Checkbox.Fluent 0.69 0.36 1.92:1 1000 685
🎯 Dialog.Fluent 0.17 0.24 0.71:1 5000 855
🔧 Dropdown.Fluent 3.14 0.42 7.48:1 1000 3143
🔧 Icon.Fluent 0.16 0.07 2.29:1 5000 788
🦄 Image.Fluent 0.09 0.14 0.64:1 5000 453
🔧 Slider.Fluent 1.64 0.47 3.49:1 1000 1639
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 418
🦄 Tooltip.Fluent 0.12 0.91 0.13:1 5000 611

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 211 185 1.14:1
FlexMinimalPerf.default 379 333 1.14:1
TooltipMinimalPerf.default 905 838 1.08:1
ButtonSlotsPerf.default 681 637 1.07:1
ChatDuplicateMessagesPerf.default 471 442 1.07:1
TextAreaMinimalPerf.default 605 567 1.07:1
Button.Fluent 634 594 1.07:1
CarouselMinimalPerf.default 507 480 1.06:1
FormMinimalPerf.default 521 492 1.06:1
ImageMinimalPerf.default 480 453 1.06:1
RefMinimalPerf.default 259 245 1.06:1
GridMinimalPerf.default 426 407 1.05:1
MenuMinimalPerf.default 1013 963 1.05:1
Tooltip.Fluent 611 584 1.05:1
LoaderMinimalPerf.default 823 790 1.04:1
RadioGroupMinimalPerf.default 514 496 1.04:1
CardMinimalPerf.default 646 627 1.03:1
ProviderMergeThemesPerf.default 2229 2161 1.03:1
SkeletonMinimalPerf.default 497 484 1.03:1
StatusMinimalPerf.default 812 790 1.03:1
IconMinimalPerf.default 727 709 1.03:1
TableMinimalPerf.default 502 487 1.03:1
Avatar.Fluent 965 939 1.03:1
ButtonUseCssNestingPerf.default 1149 1127 1.02:1
CheckboxMinimalPerf.default 2974 2922 1.02:1
DropdownMinimalPerf.default 3173 3098 1.02:1
ListNestedPerf.default 659 643 1.02:1
PopupMinimalPerf.default 762 745 1.02:1
TreeWith60ListItems.default 236 231 1.02:1
Checkbox.Fluent 685 674 1.02:1
AnimationMinimalPerf.default 455 451 1.01:1
AvatarMinimalPerf.default 517 510 1.01:1
BoxMinimalPerf.default 417 411 1.01:1
ButtonMinimalPerf.default 211 209 1.01:1
LabelMinimalPerf.default 489 486 1.01:1
LayoutMinimalPerf.default 470 464 1.01:1
ListWith60ListItems.default 1000 988 1.01:1
ReactionMinimalPerf.default 486 479 1.01:1
SplitButtonMinimalPerf.default 4191 4148 1.01:1
TextMinimalPerf.default 421 418 1.01:1
CustomToolbarPrototype.default 4158 4131 1.01:1
Dropdown.Fluent 3143 3114 1.01:1
ButtonUseCssPerf.default 901 904 1:1
DatepickerMinimalPerf.default 50087 50078 1:1
DividerMinimalPerf.default 419 417 1:1
ItemLayoutMinimalPerf.default 1462 1464 1:1
ListCommonPerf.default 763 761 1:1
PortalMinimalPerf.default 186 186 1:1
ProviderMinimalPerf.default 1139 1138 1:1
SliderMinimalPerf.default 1720 1722 1:1
Dialog.Fluent 855 858 1:1
ButtonOverridesMissPerf.default 1869 1884 0.99:1
DialogMinimalPerf.default 877 890 0.99:1
DropdownManyItemsPerf.default 840 848 0.99:1
HeaderMinimalPerf.default 437 440 0.99:1
ListMinimalPerf.default 551 556 0.99:1
MenuButtonMinimalPerf.default 1653 1673 0.99:1
VideoMinimalPerf.default 712 717 0.99:1
Icon.Fluent 788 795 0.99:1
Image.Fluent 453 456 0.99:1
Text.Fluent 418 423 0.99:1
AccordionMinimalPerf.default 185 188 0.98:1
AttachmentSlotsPerf.default 1220 1248 0.98:1
TreeMinimalPerf.default 863 879 0.98:1
EmbedMinimalPerf.default 4419 4548 0.97:1
InputMinimalPerf.default 1439 1476 0.97:1
SegmentMinimalPerf.default 390 402 0.97:1
ToolbarMinimalPerf.default 1046 1078 0.97:1
Slider.Fluent 1639 1683 0.97:1
ChatMinimalPerf.default 701 728 0.96:1
ChatWithPopoverPerf.default 520 539 0.96:1
HeaderSlotsPerf.default 929 970 0.96:1
TableManyItemsPerf.default 2385 2520 0.95:1
AlertMinimalPerf.default 364 388 0.94:1

@size-auditor
Copy link

size-auditor bot commented Dec 17, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cb8c48d775b497c7383d73d78617910bb2d5212c (build)

@chrisdholt chrisdholt merged commit 81651e8 into microsoft:master Dec 17, 2020
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v0.10.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants