Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error with newer Node versions #13433

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Fix build error with newer Node versions #13433

merged 1 commit into from
Jun 2, 2020

Conversation

ecraig12345
Copy link
Member

@ecraig12345 ecraig12345 commented Jun 2, 2020 •
edited
Loading

Pull request checklist

Description of changes

Per nodejs/node#32107 (comment) make the minimum changes required to update @babel/helper-compilation-targets to 7.8.7, which should fix a build error on newer Node versions.

@ecraig12345 ecraig12345 requested a review from jdhuntington June 2, 2020 01:05
@msft-github-bot
Copy link
Contributor

Hello @ecraig12345!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 52 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 1044 974 5000
ButtonNext 565 561 5000
Checkbox 1943 1896 5000
CheckboxBase 1631 1635 5000
CheckboxNext 1957 1817 5000
ChoiceGroup 5958 5840 5000
ComboBox 1112 1035 1000
CommandBar 9014 8990 1000
ContextualMenu 18895 18672 1000
DefaultButton 1334 1291 5000
DetailsRow 4162 4108 5000
DetailsRow (fast icons) 4182 4124 5000
DetailsRow without styles 3951 3878 5000
Dialog 1739 1764 1000
DocumentCardTitle with truncation 2169 2162 1000
Dropdown 2928 2896 5000
FocusZone 2051 2064 5000
IconButton 2081 2064 5000
Label 360 376 5000
Link 544 581 5000
LinkNext 568 595 5000
MenuButton 1727 1699 5000
Nav 3838 3837 1000
Panel 1678 1692 1000
Persona 959 997 1000
Pivot 1689 1678 1000
PivotNext 941 937 5000
PrimaryButton 1483 1435 5000
SearchBox 1573 1528 5000
Slider 1804 1783 5000
SliderNext 2256 2403 5000
Spinner 468 504 5000
SplitButton 3659 3688 5000
Stack 624 563 5000
Stack with Intrinsic children 2435 2398 5000
Stack with Text children 6199 6171 5000
TagPicker 3460 3310 5000
Text 475 470 5000
TextField 1693 1725 5000
ThemeProvider 3320 3194 5000
Toggle 1025 1014 5000
ToggleNext 990 1068 5000
button 109 104 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.85 0.56 1.52:1 2000 1707
🦄 Button.Fluent 0.14 0.23 0.61:1 5000 707
🔧 Checkbox.Fluent 1.34 0.4 3.35:1 1000 1335
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 811
🔧 Dropdown.Fluent 8.15 0.53 15.38:1 1000 8154
🔧 Icon.Fluent 0.18 0.06 3:1 5000 906
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 457
🔧 Slider.Fluent 3.59 0.42 8.55:1 1000 3589
🔧 Text.Fluent 0.09 0.03 3:1 5000 434
🦄 Tooltip.Fluent 0.11 22.61 0:1 5000 571

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 418 346 1.21:1
PortalMinimalPerf.default 145 123 1.18:1
TooltipMinimalPerf.default 932 824 1.13:1
Icon.Fluent 906 812 1.12:1
ButtonMinimalPerf.default 208 188 1.11:1
BoxMinimalPerf.default 428 389 1.1:1
ChatMinimalPerf.default 712 662 1.08:1
PopupMinimalPerf.default 305 282 1.08:1
DialogMinimalPerf.default 876 819 1.07:1
DropdownManyItemsPerf.default 2872 2695 1.07:1
HierarchicalTreeMinimalPerf.default 497 463 1.07:1
ListMinimalPerf.default 602 562 1.07:1
ReactionMinimalPerf.default 510 475 1.07:1
RefMinimalPerf.default 231 216 1.07:1
MenuButtonMinimalPerf.default 1494 1410 1.06:1
ProviderMergeThemesPerf.default 2491 2352 1.06:1
CustomToolbarPrototype.default 6527 6147 1.06:1
DividerMinimalPerf.default 433 413 1.05:1
ListNestedPerf.default 1444 1369 1.05:1
Slider.Fluent 3589 3412 1.05:1
FormMinimalPerf.default 512 491 1.04:1
HeaderSlotsPerf.default 896 865 1.04:1
MenuMinimalPerf.default 980 944 1.04:1
Button.Fluent 707 677 1.04:1
ChatWithPopoverPerf.default 630 614 1.03:1
RadioGroupMinimalPerf.default 480 466 1.03:1
Avatar.Fluent 1707 1660 1.03:1
CheckboxMinimalPerf.default 6588 6459 1.02:1
EmbedMinimalPerf.default 4374 4303 1.02:1
ImageMinimalPerf.default 436 426 1.02:1
ItemLayoutMinimalPerf.default 2985 2925 1.02:1
TableManyItemsPerf.default 3046 2997 1.02:1
TreeMinimalPerf.default 1697 1658 1.02:1
AttachmentMinimalPerf.default 183 182 1.01:1
CardMinimalPerf.default 685 679 1.01:1
FlexMinimalPerf.default 349 344 1.01:1
GridMinimalPerf.default 1754 1745 1.01:1
LayoutMinimalPerf.default 478 472 1.01:1
ProviderMinimalPerf.default 1094 1084 1.01:1
SplitButtonMinimalPerf.default 4115 4071 1.01:1
TableMinimalPerf.default 490 483 1.01:1
ToolbarMinimalPerf.default 1126 1120 1.01:1
AccordionMinimalPerf.default 188 188 1:1
AttachmentSlotsPerf.default 1528 1521 1:1
StatusMinimalPerf.default 835 835 1:1
Dialog.Fluent 811 812 1:1
Dropdown.Fluent 8154 8178 1:1
Text.Fluent 434 432 1:1
AnimationMinimalPerf.default 973 978 0.99:1
CarouselMinimalPerf.default 624 629 0.99:1
LabelMinimalPerf.default 503 510 0.99:1
SegmentMinimalPerf.default 421 426 0.99:1
ButtonSlotsPerf.default 910 932 0.98:1
ListWith60ListItems.default 1908 1956 0.98:1
IconMinimalPerf.default 819 839 0.98:1
TextMinimalPerf.default 416 425 0.98:1
Checkbox.Fluent 1335 1364 0.98:1
Image.Fluent 457 468 0.98:1
Tooltip.Fluent 571 582 0.98:1
HeaderMinimalPerf.default 427 441 0.97:1
InputMinimalPerf.default 2002 2054 0.97:1
LoaderMinimalPerf.default 1388 1428 0.97:1
VideoMinimalPerf.default 721 740 0.97:1
DropdownMinimalPerf.default 7912 8254 0.96:1
ChatDuplicateMessagesPerf.default 654 690 0.95:1
SliderMinimalPerf.default 3463 3632 0.95:1
AlertMinimalPerf.default 409 435 0.94:1
TextAreaMinimalPerf.default 549 581 0.94:1
ListCommonPerf.default 1406 1518 0.93:1
AvatarMinimalPerf.default 900 973 0.92:1

@size-auditor
Copy link

size-auditor bot commented Jun 2, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: fcf0cd90a65e814c403de01cea4d239ff9a59177 (build)

@dzearing dzearing merged commit 6596441 into microsoft:master Jun 2, 2020
miroslavstastny pushed a commit to levithomason/fluentui that referenced this pull request Jun 8, 2020
@ecraig12345 @miroslavstastny
Fix build error with newer Node versions (microsoft#13433)
c431266
@ecraig12345 ecraig12345 deleted the exports-error branch August 28, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhuntington jdhuntington Awaiting requested review from jdhuntington

Assignees

@jdhuntington jdhuntington

Labels
Area: Build System AutoMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to build
4 participants
@ecraig12345 @msft-github-bot @jdhuntington @dzearing