-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: The PopoverSurface doesn't close automatically when the Popover is used with closeOnScroll #28938
Comments
I'm investigating this |
May be fixed by #28938. |
could you give more details about the fix? |
@zhangxuan615 both bugs in this issue are fixed by #29062. This is a new codesandbox built from the latest release, could you verify that it fixes your issues? https://codesandbox.io/s/dreamy-hooks-9zv3g5?file=/example.tsx |
Reopening this issue as previous fix #29062 was reverted #29412. The original issue is that dragging scrollbar does not close Popover with closeOnScroll. To close popover on dragging scrollbar, #29412 tries to listen to scroll event because when dragging scrollbar, |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Currently, there's no reliable method to accurately decide if the scrollbar is being dragged. Given this limitation, which stems from the current capabilities of web browsers, I'm closing this issue. We are open to revisiting this issue if there are ways to accurately decide scrollbar dragging. |
Library
React Components / v9 (@fluentui/react-components)
System Info
Are you reporting Accessibility issue?
None
Reproduction
https://codesandbox.io/s/inspiring-fast-5jm9wc?file=/example.tsx
Bug Description
Actual Behavior
steps to repro:
2.1. click the trigger to open the PopoverSurface. (keep the mouse hover on the trigger)
2.2. scroll the wheel of mouse coninously to drive the cursor walking away from the trigger.
2.3. you can still see the PopoverSurface open when you stop scrolling although the PopoverSurface was supposed to be closed.
Expected Behavior
both should close PopoverSurface
Logs
No response
Requested priority
High
Products/sites affected
No response
Are you willing to submit a PR to fix?
no
Validations
The text was updated successfully, but these errors were encountered: